[Commits] [wesnoth/wesnoth] a7095b: fixup party full bell

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a7095b458842acd68570bade506762605cae0952
      https://github.com/wesnoth/wesnoth/commit/a7095b458842acd68570bade506762605cae0952
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M src/multiplayer_connect.cpp
    M src/multiplayer_connect_engine.cpp

  Log Message:
  -----------
  fixup party full bell

the party full bell code is moved back to the engine, and is
based on checking whether processing the most recent message
has made it now possible to start the game. this seems to be
the simplest logic that will do the right thing, it will now
make the bell play whenever the "I'm ready" button is active

this also addresses bug #21910.

note: the reason we don't check the "silent" flag is that it
causes the sound not to be played in some circumstances where
it should. multiplayer_connect_engine currently returns
value "true" for silent (the second part of result) in all
cases except when a player has been successfully assigned to
a side, in which case it is false. depending on the status of
allow_changes, that might be a time that we want to play the
"ready to start" bell.


  Commit: 68d92864f9b16cf78ca8b7ac41ee34ffd16c61e3
      https://github.com/wesnoth/wesnoth/commit/68d92864f9b16cf78ca8b7ac41ee34ffd16c61e3
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M src/multiplayer_connect.cpp

  Log Message:
  -----------
  provide a desktop notification when game is ready to start

this is played at the same time as the turn bell, it is effectively
the same as a chat message which will cause a desktop popup on
systems that we support this for.

note: we don't check notification preference, because this should
be done in the show_notification function, not the caller.
however, it seems that is only done with DBUS notifications? why
not others?


  Commit: d8ae9fc970837f248d07a92d541b9cb13a45f423
      https://github.com/wesnoth/wesnoth/commit/d8ae9fc970837f248d07a92d541b9cb13a45f423
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M src/multiplayer_wait.cpp

  Log Message:
  -----------
  add game start notification

this is similar to previous commit which adds a "party full"
notification

note: we don't check the notification preference as this should be done
in the notification function and not by the caller. however, it seems
this is only done with DBUS notifications currently? see previous commit
message...


  Commit: 46850f271a3a6c4fb2025aa50c70b5c59ecbce35
      https://github.com/wesnoth/wesnoth/commit/46850f271a3a6c4fb2025aa50c70b5c59ecbce35
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M changelog
    M players_changelog

  Log Message:
  -----------
  update changelogs


Compare: https://github.com/wesnoth/wesnoth/compare/0f6c7acb08bb...46850f271a3a