[Commits] [wesnoth/wesnoth] 86b68c: add precise_timestamps setter

GitHub noreply at github.com
Sun Apr 27 18:03:30 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 86b68cf8d6077034e8273f72005148ce4d0e53bf
      https://github.com/wesnoth/wesnoth/commit/86b68cf8d6077034e8273f72005148ce4d0e53bf
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/log.cpp
    M src/log.hpp

  Log Message:
  -----------
  add precise_timestamps setter


  Commit: 03721d9fe6e43e02c4754ab5e6bb3669f087c5c7
      https://github.com/wesnoth/wesnoth/commit/03721d9fe6e43e02c4754ab5e6bb3669f087c5c7
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp
    M src/game.cpp

  Log Message:
  -----------
  commandline option for precise timestamps


  Commit: 02a97838b827743adbf375dc2f9a69b6630226f4
      https://github.com/wesnoth/wesnoth/commit/02a97838b827743adbf375dc2f9a69b6630226f4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/ai/lua/core.cpp
    M src/ai/lua/lua_object.hpp
    M src/config.cpp
    M src/events.cpp
    M src/global.hpp
    M src/gui/auxiliary/event/distributor.cpp
    M src/joystick.cpp
    M src/overlay.hpp
    M src/scripting/lua.cpp
    M src/scripting/lua_api.cpp
    M src/scripting/lua_api.hpp
    M src/serialization/tokenizer.hpp
    M src/unit.cpp
    M src/unit_frame.cpp
    M src/unit_frame.hpp
    M src/whiteboard/move.cpp

  Log Message:
  -----------
  enable msvc bool conversion check.

we now enable warning 4800. I ran though the msvc compile with this
warning and i found some (in overlay.hpp, unit.cpp, whiteboard/move.cpp)
unintended implicit bool b = cfg["attributename"] casts that use
the implicit attribute_value to int cast and then a int to bool cast.
So for attributename=true b would be false. So i believe this
is a useful warning.

There are also a lot of implicit int to bool cast from the SDL and LUA
C-libraries which use int instead of bool because C doesn't have bool.
In this case this warning is less useful, but i still think it's worth
it since a "!= 0" or "== 1" isn't cost.

Plus if someone really wants to disable this warning he can still
disable it in the msvc project settings, while before is was not
possible for someone to enable this warning the the settings.


  Commit: 357d1a4ce3c3951133739afdf1a21c9f09987b5a
      https://github.com/wesnoth/wesnoth/commit/357d1a4ce3c3951133739afdf1a21c9f09987b5a
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/replay.cpp
    M src/replay.hpp

  Log Message:
  -----------
  more robust replay.cpp functions

we now add nonundoable commands at the current position instead of
assuming
at_end(), this way nonundoable replay entrys like speak can now also be
added
while we are not at end.
Usually playturn_network_adapter ensures that we are always are at_end()
and i didn't get any error with the previous solution but the new
solution
is just more robust in case something goes wrong.
Note that we cannot add nonundoable commands at end if we aren’t at end
because
in that case the user would see the message again when he replays it.
Note that we cannot just do this for normal command because it might
bring the
replay in disorder.


  Commit: 5bf4125bf972b751a3ceabb708f3bb76ef72455b
      https://github.com/wesnoth/wesnoth/commit/5bf4125bf972b751a3ceabb708f3bb76ef72455b
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/replay.cpp
    M src/replay.hpp

  Log Message:
  -----------
  tidyup replay.cpp


  Commit: 7a46832348ba7fd5eebf6a12aabeca2f5b1a0e8d
      https://github.com/wesnoth/wesnoth/commit/7a46832348ba7fd5eebf6a12aabeca2f5b1a0e8d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-04-27 (Sun, 27 Apr 2014)

  Changed paths:
    M src/actions/move.cpp

  Log Message:
  -----------
  more robust replaying of moves

we now set skipsighted to true if there is no fog or shroud.
The intention is that if a player uses fog=no in debugmode we still get
the same move destination in replays.


Compare: https://github.com/wesnoth/wesnoth/compare/bbffa5e88ad8...7a46832348ba


More information about the Commits mailing list