[Commits] [wesnoth/wesnoth] 1ebadb: wmllint: split introduction into labeled sections ...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1ebadbf7c4379510de766b81835ed71146766d21
      https://github.com/wesnoth/wesnoth/commit/1ebadbf7c4379510de766b81835ed71146766d21
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-08-01 (Fri, 01 Aug 2014)

  Changed paths:
    M data/tools/wmllint

  Log Message:
  -----------
  wmllint: split introduction into labeled sections for clarity

Also, the top paragraphs, aimed at the core developers, have been moved to
the bottom, to get to the information key to general users.


  Commit: ea380c21c4aaee2ae48f44647aa249f5c5b2c6b5
      https://github.com/wesnoth/wesnoth/commit/ea380c21c4aaee2ae48f44647aa249f5c5b2c6b5
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-08-01 (Fri, 01 Aug 2014)

  Changed paths:
    M data/tools/wmlscope

  Log Message:
  -----------
  wmlscope: import glob for Windows shell

The Windows cmd shell will not expand a globbed argument by default, in
fact it will make the argument invalid. Importing and utilizing the glob
module is needed for x-platform.

Globbing is especially important for breaking up the subtree, so wmlscope
doesn't give off "more than one resource/definition is visible here"
errors.


  Commit: 6a1a369ad1319300ca308c0423bc86e93915cc5d
      https://github.com/wesnoth/wesnoth/commit/6a1a369ad1319300ca308c0423bc86e93915cc5d
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-08-01 (Fri, 01 Aug 2014)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: cite define locations when "more than one definition" is visible

When "more than one resource" is visible, wmlscope tells you where they
are.  Now it will do the same for macro definitions.


  Commit: 975ff7b0c34a1e55c3b3ee9f8de6c1764f6d29f8
      https://github.com/wesnoth/wesnoth/commit/975ff7b0c34a1e55c3b3ee9f8de6c1764f6d29f8
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-08-01 (Fri, 01 Aug 2014)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: fix wmlscope crash in collection of unresolved macro calls

While testing wmlscope without including data/core, which guarantees lots
of "unresolved" references, I got a crash pointing to this line with the
traceback: "NameError: global name 'args' is not defined".

At first, I thought the crash might have been caused by my splitting out
parse_macroref into its own function, several months ago. However, the
line is at the wrong indentation level for those "args" to be the variable
referenced here. So what "args" might have been intended?

After tracking down the commit that added "args=args" to this line, I've
concluded that this was simply a mistake. ESR isn't around to ask anymore,
but if a macro was never defined, or is not called correctly, what "args"
could be relevant?


Compare: https://github.com/wesnoth/wesnoth/compare/de48c18618de...975ff7b0c34a