[Commits] [wesnoth/wesnoth] 856f3a: check properly if a config attribute value is not ...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 856f3acab730965b7849802c752f9f751b6fc1fe
      https://github.com/wesnoth/wesnoth/commit/856f3acab730965b7849802c752f9f751b6fc1fe
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-25 (Tue, 25 Nov 2014)

  Changed paths:
    M src/multiplayer_connect_engine.cpp

  Log Message:
  -----------
  check properly if a config attribute value is not a boolean

I don't know if this commit is related to or fixes any bugs, but
there are many bugs reported about fog / shroud / mp campaigns it
seems, and these lines always looked a bit squirrely to me. Since
boolean config values can be indicated by "yes", "no", "true" or
"false", testing for the presence of "yes" / "no" only seems like
it won't work in general, even if it works oftentimes. This commit
replaces it with a test for whether the to_bool function is
selecting the default boolean value.


  Commit: 2fa43e3df9ba557015688ba39be5213521e64cd3
      https://github.com/wesnoth/wesnoth/commit/2fa43e3df9ba557015688ba39be5213521e64cd3
  Author: Chris Beck <beck.ct at gmail.com>
  Date:   2014-11-30 (Sun, 30 Nov 2014)

  Changed paths:
    M src/multiplayer_connect_engine.cpp

  Log Message:
  -----------
  Merge pull request #335 from cbeck88/mp_connect_bool_test

check properly if a config attribute value is not a boolean


Compare: https://github.com/wesnoth/wesnoth/compare/7ae79e8b18e9...2fa43e3df9ba