[Commits] [wesnoth/wesnoth] c3268b: Refactor part of the load game code to remove load...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c3268b816ba099ce5193c2689ba2787e345ae519
      https://github.com/wesnoth/wesnoth/commit/c3268b816ba099ce5193c2689ba2787e345ae519
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-14 (Sun, 14 Dec 2014)

  Changed paths:
    M src/game_initialization/multiplayer_create.cpp
    M src/game_launcher.cpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Refactor part of the load game code to remove load_game_canceled_exception

Instead of throwing an exception, the relevant functions will return a false bool


  Commit: 7441a53a17b9582cc14e65b4b10e815c33205315
      https://github.com/wesnoth/wesnoth/commit/7441a53a17b9582cc14e65b4b10e815c33205315
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-12-14 (Sun, 14 Dec 2014)

  Changed paths:
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  in in-game load dialog, check health and version before exit game

This is fixes a minor bug:
When loading a save from the in-game load dialog, as soon as the
user clicks "ok" to load a savefile, an exception would be thrown
which effectively quits the game, before determining the integrity
and version info of that file.

It's better not to exit a running game if the new game can't be
loaded, so in this commit check these things and abort before
exiting if appropriate.


  Commit: c9f5d7e8296159c8ca7739019273901cc4f17c59
      https://github.com/wesnoth/wesnoth/commit/c9f5d7e8296159c8ca7739019273901cc4f17c59
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-14 (Sun, 14 Dec 2014)

  Changed paths:
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Remove usecases of illegal_filename_exception


  Commit: 5a7f2becf02a5295b544eee5016f99f9f71419c6
      https://github.com/wesnoth/wesnoth/commit/5a7f2becf02a5295b544eee5016f99f9f71419c6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-14 (Sun, 14 Dec 2014)

  Changed paths:
    M src/game_initialization/multiplayer_create.cpp
    M src/savegame.cpp

  Log Message:
  -----------
  Small formatting fixes


  Commit: 615d4024ce0e9391e387025a4d3b0294e7fad63c
      https://github.com/wesnoth/wesnoth/commit/615d4024ce0e9391e387025a4d3b0294e7fad63c
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-12-14 (Sun, 14 Dec 2014)

  Changed paths:
    M src/game_errors.cpp
    M src/game_errors.hpp
    M src/game_launcher.cpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  don't ask the user twice about old version when loading a save

The issue only affected saves loaded from the in-game menu.


  Commit: ec72d91bb1c06c3bcd2cc249ebb1621119755a93
      https://github.com/wesnoth/wesnoth/commit/ec72d91bb1c06c3bcd2cc249ebb1621119755a93
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-15 (Mon, 15 Dec 2014)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  Don't show version check when reloading via 'Back to [...]' menu items


  Commit: 552d1bf7b7e3d4dd86c1b48e3f9d6d8fe0a04988
      https://github.com/wesnoth/wesnoth/commit/552d1bf7b7e3d4dd86c1b48e3f9d6d8fe0a04988
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-15 (Mon, 15 Dec 2014)

  Changed paths:
    M changelog

  Log Message:
  -----------
  Updated changelog


  Commit: db39fd57ecd8d62aa5d093a18176e0374636abed
      https://github.com/wesnoth/wesnoth/commit/db39fd57ecd8d62aa5d093a18176e0374636abed
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2014-12-15 (Mon, 15 Dec 2014)

  Changed paths:
    M changelog
    M src/game_errors.cpp
    M src/game_errors.hpp
    M src/game_initialization/multiplayer_create.cpp
    M src/game_launcher.cpp
    M src/play_controller.cpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Merge pull request #344 from Vultraz/vult-remove-savegame-exceptions

Optimize and improve loadgame interface


Compare: https://github.com/wesnoth/wesnoth/compare/41d9b045c200...db39fd57ecd8