[Commits] [wesnoth/wesnoth] 6fe72e: Skip generating help sections for units without hi...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6fe72e893fbfdf38832e457a671aebdc16266e87
      https://github.com/wesnoth/wesnoth/commit/6fe72e893fbfdf38832e457a671aebdc16266e87
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-12-22 (Mon, 22 Dec 2014)

  Changed paths:
    M changelog
    M players_changelog
    M src/editor/controller/editor_controller.cpp
    M src/help/help.cpp
    M src/help/help_impl.cpp
    M src/reports.cpp
    M src/unit_types.cpp
    M src/unit_types.hpp

  Log Message:
  -----------
  Skip generating help sections for units without hide_help=no variations

This fixes many instances of unit types with "technical" variations in
my campaign After the Storm being assigned help sections of their own.

Required adding a new method to unit_type that's actually cheaper than
checking for variations().empty(), as it doesn't involve allocating new
objects.