[Commits] [wesnoth/wesnoth-old] 35961b: Avoid an unnecessary copy of a string.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth-old
  Commit: 35961bd4b64b7245e14897329a0220fdb8e9f4d2
      https://github.com/wesnoth/wesnoth-old/commit/35961bd4b64b7245e14897329a0220fdb8e9f4d2
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-09 (Sun, 09 Feb 2014)

  Changed paths:
    M src/actions/create.cpp

  Log Message:
  -----------
  Avoid an unnecessary copy of a string.


  Commit: 97eb5ab8c9be4b2a86a7265d86d370f42114fc13
      https://github.com/wesnoth/wesnoth-old/commit/97eb5ab8c9be4b2a86a7265d86d370f42114fc13
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-09 (Sun, 09 Feb 2014)

  Changed paths:
    M src/actions/create.cpp

  Log Message:
  -----------
  Limit variable scope.

Issue found by cppcheck.


  Commit: ff4c0ebb096d03b5357d2c284f83baa04e73b321
      https://github.com/wesnoth/wesnoth-old/commit/ff4c0ebb096d03b5357d2c284f83baa04e73b321
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-09 (Sun, 09 Feb 2014)

  Changed paths:
    M src/help.cpp

  Log Message:
  -----------
  Pre instead of post increment a variable.

Issue found by cppcheck.


  Commit: 837bf59b8be2f317a616a83208ea41a1ba941c64
      https://github.com/wesnoth/wesnoth-old/commit/837bf59b8be2f317a616a83208ea41a1ba941c64
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-09 (Sun, 09 Feb 2014)

  Changed paths:
    M src/game_preferences_display.cpp

  Log Message:
  -----------
  Validate a pointer before deferring it.

The problem was introduced in 818ffad0, David Mikos please review this
patch.

Issue found by cppcheck.


  Commit: 5fe1dbf88364b37403caf09f8947d98b2d66b851
      https://github.com/wesnoth/wesnoth-old/commit/5fe1dbf88364b37403caf09f8947d98b2d66b851
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-09 (Sun, 09 Feb 2014)

  Changed paths:
    M src/editor/map/context_manager.hpp

  Log Message:
  -----------
  Remove an unused private function.

Issue found by cppcheck.


Compare: https://github.com/wesnoth/wesnoth-old/compare/b488db4bc3ca...5fe1dbf88364