[Commits] [wesnoth/wesnoth-old] 9bcfef: Fix drawing the offmap area for small resolutions.

GitHub noreply at github.com
Sat Feb 15 16:13:58 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth-old
  Commit: 9bcfeffc4204d645fd4890443397c09272b4ac73
      https://github.com/wesnoth/wesnoth-old/commit/9bcfeffc4204d645fd4890443397c09272b4ac73
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-15 (Sat, 15 Feb 2014)

  Changed paths:
    M changelog
    M data/themes/editor.cfg

  Log Message:
  -----------
  Fix drawing the offmap area for small resolutions.

The problem was a bit tricky. A partial resolution removed an element with
an empty id. The main_map_border section has no id and thus an empty id.
So the inheritance removed this section by accident. Of course the id for
a removal or change should be mandatory, which the next patch will do.

This fixes a part of bug #21584.


  Commit: e6df6f7b8728b054f6c8ccca461035fb98aaeb62
      https://github.com/wesnoth/wesnoth-old/commit/e6df6f7b8728b054f6c8ccca461035fb98aaeb62
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-15 (Sat, 15 Feb 2014)

  Changed paths:
    M changelog
    M src/theme.cpp

  Log Message:
  -----------
  Disallow change and remove sections without an id.

This change to the ThemeWML will avoid the offmap drawing issues due to
accidentaly changing or removing the main_map_border section from a
resolution. If it is really wanted it is possible to add an id to this
section, the game doesn't use it, but inheritance uses the raw config.

This fix rewrites the expand_partialresolution, adding the check and
making the code easier to follow.

This should avoid bugs like bug #21584.


  Commit: 136f38c6422a12a16638e3cab1c94c7e74dde1ad
      https://github.com/wesnoth/wesnoth-old/commit/136f38c6422a12a16638e3cab1c94c7e74dde1ad
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-15 (Sat, 15 Feb 2014)

  Changed paths:
    M changelog
    M src/display.cpp

  Log Message:
  -----------
  Properly redraw the minimap upon resizing.

When the main screen and in turn caused the minimap to resize this change
was not propagated to the minimap until one of the minimap view buttons
was pressed.

This fixes a part of bug #21584.


  Commit: 56b18db1fc07d13d83446bc3e7c1763f5cc9eb52
      https://github.com/wesnoth/wesnoth-old/commit/56b18db1fc07d13d83446bc3e7c1763f5cc9eb52
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-02-15 (Sat, 15 Feb 2014)

  Changed paths:
    M changelog
    M data/themes/editor.cfg
    M src/display.cpp
    M src/theme.cpp

  Log Message:
  -----------
  Merge branch 'bug_21584'

Fixes bug #21584.


Compare: https://github.com/wesnoth/wesnoth-old/compare/f16c90be765e...56b18db1fc07


More information about the Commits mailing list