[Commits] [wesnoth/wesnoth] 3d183d: addon/mg: Rework the Update All action logic for g...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3d183dbd91ce1e62bcbfc3d6fa468c3d7ab07e41
      https://github.com/wesnoth/wesnoth/commit/3d183dbd91ce1e62bcbfc3d6fa468c3d7ab07e41
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-06 (Sun, 06 Jul 2014)

  Changed paths:
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Rework the Update All action logic for genericity

Instead of assuming that the currently visible options are all
upgradable (an assumption that proved true up to this day, but will not
in the next commit), go over them and make sure that their state truly
is ADDON_INSTALLED_UPGRADABLE.

This will allow Update All to work as intended on any view, and not just
those including upgradable add-ons only.


  Commit: 9407f4ab816b23c571509cbdd521c07840298d0f
      https://github.com/wesnoth/wesnoth/commit/9407f4ab816b23c571509cbdd521c07840298d0f
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-06 (Sun, 06 Jul 2014)

  Changed paths:
    M changelog
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Include Update All on all views and enable it when applicable

This makes it so the Update All button appears on all views, disabled by
default unless there is at least one ADDON_INSTALLED_UPGRADABLE add-on.

The rationale for this is that with the Update Add-ons shortcut in the
Connect dialog gone, the possibility of upgrading installed add-ons is
not as visible as it was in versions 1.5.3 through 1.10.x. Making the
button visible at all times should hint at the existence of this
functionality.


  Commit: d1f1819fc909da84534e1aa24433ce566f92a658
      https://github.com/wesnoth/wesnoth/commit/d1f1819fc909da84534e1aa24433ce566f92a658
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-06 (Sun, 06 Jul 2014)

  Changed paths:
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Choose "update" vs. "install" terms when using Update All too

Previously the "update" terminology was only used when the Upgradable
view was the active view. Now that the Update All action may be
available on other views, we need to take care to use the correct terms
for it too.

This commit incurs in no changes to existing translatable strings.


Compare: https://github.com/wesnoth/wesnoth/compare/69a2457a5b67...d1f1819fc909