[Commits] [wesnoth/wesnoth] b03789: addon/mg: Rework the Update All action logic for g...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b0378981f5f4ef6c754a86bd8e8bf0b6117da369
      https://github.com/wesnoth/wesnoth/commit/b0378981f5f4ef6c754a86bd8e8bf0b6117da369
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Rework the Update All action logic for genericity

Instead of assuming that the currently visible options are all
upgradable (an assumption that proved true up to this day, but will not
in the next commit), go over them and make sure that their state truly
is ADDON_INSTALLED_UPGRADABLE.

This will allow Update All to work as intended on any view, and not just
those including upgradable add-ons only.


  Commit: c895105a70e89181af9ba54296d2e7f90fb94a19
      https://github.com/wesnoth/wesnoth/commit/c895105a70e89181af9ba54296d2e7f90fb94a19
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M players_changelog
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Include Update All on all views and enable it when applicable

This makes it so the Update All button appears on all views, disabled by
default unless there is at least one ADDON_INSTALLED_UPGRADABLE add-on.

The rationale for this is that with the Update Add-ons shortcut in the
Connect dialog gone, the possibility of upgrading installed add-ons is
not as visible as it was in versions 1.5.3 through 1.10.x. Making the
button visible at all times should hint at the existence of this
functionality.


  Commit: e98d21f6821746d9c3fa10f1ee169ad5186fb3ae
      https://github.com/wesnoth/wesnoth/commit/e98d21f6821746d9c3fa10f1ee169ad5186fb3ae
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/addon/manager_ui.cpp

  Log Message:
  -----------
  addon/mg: Choose "update" vs. "install" terms when using Update All too

Previously the "update" terminology was only used when the Upgradable
view was the active view. Now that the Update All action may be
available on other views, we need to take care to use the correct terms
for it too.

This commit incurs in no changes to existing translatable strings.


  Commit: ba6f680a7e28bcd2a144481849372226e2d58a24
      https://github.com/wesnoth/wesnoth/commit/ba6f680a7e28bcd2a144481849372226e2d58a24
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp

  Log Message:
  -----------
  Simplify --resolution error handling

Reuse the boost::program_options::error class (which we already catch in
main()) instead of throwing a std::string, and simplify the throwing
logic accordingly.

There is no need to provide incredibly verbose error messages since the
user is expected to be able to read --help or the man page to get here
in the first place.


  Commit: 8471d63fb00384b4f5a8b52ae5c93fc0b640c7b8
      https://github.com/wesnoth/wesnoth/commit/8471d63fb00384b4f5a8b52ae5c93fc0b640c7b8
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/commandline_options.cpp
    M src/commandline_options.hpp

  Log Message:
  -----------
  Simplify tuple command line arguments error handling

Reuse the boost::program_options::error class (which we already catch in
main()) instead of throwing a std::string, and simplify the throwing
logic accordingly.

There is no need to provide incredibly verbose error messages since the
user is expected to be able to read --help or the man page to get here
in the first place.


  Commit: 919ad1595429714dabfcc5887552c6f4005cb6db
      https://github.com/wesnoth/wesnoth/commit/919ad1595429714dabfcc5887552c6f4005cb6db
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-07-07 (Mon, 07 Jul 2014)

  Changed paths:
    M src/commandline_options.cpp

  Log Message:
  -----------
  Remove unneeded header inclusion

It seems somebody was using kdevelop for commit
f6b0ef01b7a412804bb37fb9499bf4395132b062.


Compare: https://github.com/wesnoth/wesnoth/compare/da728d174444...919ad1595429