[Commits] [wesnoth/wesnoth] a39bfe: give a warning when notifications enabled but not ...

GitHub noreply at github.com
Mon Jul 14 03:23:18 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a39bfea9920c52949fa4160bc32c88d834aef4b8
      https://github.com/wesnoth/wesnoth/commit/a39bfea9920c52949fa4160bc32c88d834aef4b8
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-13 (Sun, 13 Jul 2014)

  Changed paths:
    M src/game_preferences_display.cpp
    M src/notifications/notifications.cpp
    M src/notifications/notifications.hpp

  Log Message:
  -----------
  give a warning when notifications enabled but not available

The "disable notifications" option in advanced preferences allows
the user to toggle desktop notifications on and off. However, if
the game was not compiled with support for these, the option won't
do anything.

In this revision, if disable_notifications is set to false, but
notifications are not available, a dialog is launched which
explains that this executable was not compiled with support for
notifications.

The preference *is* toggled however -- this is because all versions
of wesnoth use the same preference file (at least under linux), so
we would rather to allow the user to change the file at will --
a different wesnoth binary which they have may indeed support
notifications. So we only give a warning but allow them to toggle.





More information about the Commits mailing list