[Commits] [wesnoth/wesnoth] c39fda: make the help smarter -- musthave traits without f...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c39fdae486221a1c8593c0675310dcbb7987b901
      https://github.com/wesnoth/wesnoth/commit/c39fdae486221a1c8593c0675310dcbb7987b901
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-17 (Thu, 17 Jul 2014)

  Changed paths:
    M src/help.cpp
    M src/movetype.cpp
    M src/movetype.hpp

  Log Message:
  -----------
  make the help smarter -- musthave traits without filters are applied

When a unit type has "musthave" traits which always apply, by
virtue of not having a filter, and they affect movement type,
resistance, or jamming / vision data, the "base" unit type data
is updated with these effects when displayed in the help.

The only mainline example I know of where this makes a change is
that the "feral" trait results in a "defense capped" column being
generated by the help. But it can be tested that if core files
are modified so that a musthave trait which always applies makes
a change to the movement type or resistances, then this will be
displayed in the help page for that unit type.

It might also be handy for certain UMC which makes use of racial
traits to modify stats.

Note that we don't at the moment:
- Update health or mp of the unit, or it's experience, according
to such trait effects.
- Update the unit with added / removed abilities due to such trait
effects.

So the help could be smarter still.