[Commits] [wesnoth/wesnoth] a9879f: fix copy assignment operator for unit class to wor...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a9879f827452141d8b9ef794da9e5e40b2ad63ca
      https://github.com/wesnoth/wesnoth/commit/a9879f827452141d8b9ef794da9e5e40b2ad63ca
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-22 (Tue, 22 Jul 2014)

  Changed paths:
    M src/unit.cpp

  Log Message:
  -----------
  fix copy assignment operator for unit class to work with refcount

This issue was spotted by gfgtdf. It doesn't appear that we
actually use this function -- prior to this commit, I tested a
version which had "assert(false)" at the start of this function,
and it was never triggered in normal play. But it's possible that
some lua command or obscure WML tag does use it.

It might also be a good idea to make the unit class noncopyable.


  Commit: b548a90c651941bd0a1446c898101d8b4e667eb8
      https://github.com/wesnoth/wesnoth/commit/b548a90c651941bd0a1446c898101d8b4e667eb8
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-22 (Tue, 22 Jul 2014)

  Changed paths:
    M src/dialogs.cpp
    M src/dialogs.hpp
    M src/display.cpp
    M src/display.hpp
    M src/game_display.cpp
    M src/marked-up_text.cpp
    M src/marked-up_text.hpp
    M src/minimap.cpp
    M src/sdl/image.cpp
    M src/sdl/image.hpp
    M src/show_dialog.cpp
    M src/show_dialog.hpp
    M src/text.cpp
    M src/text.hpp

  Log Message:
  -----------
  Merge branch 'master' of git://github.com/wesnoth/wesnoth


Compare: https://github.com/wesnoth/wesnoth/compare/722f10b1f270...b548a90c6519