[Commits] [wesnoth/wesnoth] 7cd958: Fix utf8::lowercase (bug #22139)

GitHub noreply at github.com
Wed Jun 4 09:40:40 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7cd9583bdd2fa06b12a08d074a17ab29316adb5a
      https://github.com/wesnoth/wesnoth/commit/7cd9583bdd2fa06b12a08d074a17ab29316adb5a
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-04 (Wed, 04 Jun 2014)

  Changed paths:
    M src/serialization/string_utils.cpp
    M src/tests/test_util.cpp

  Log Message:
  -----------
  Fix utf8::lowercase (bug #22139)

As ucs4::char is unsigned, we don't need to compare against the min value of
the type. Worse, we cast the (possibly signed) min value to ucs4::char, which
on plenty of systems, results in 2^31, excluding all valid unicode codepoints.

Fix by gfgtdf.
Patch by iceiceice. (PR #189)
Commit message by ai0867.

Conflicts:
	src/serialization/unicode.cpp
	src/tests/test_util.cpp





More information about the Commits mailing list