[Commits] [wesnoth/wesnoth] 4406cd: add accessors for selected, moused-over hex to cla...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4406cdfae0788533b31b4bf0667cf532d85f2060
      https://github.com/wesnoth/wesnoth/commit/4406cdfae0788533b31b4bf0667cf532d85f2060
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.hpp

  Log Message:
  -----------
  add accessors for selected, moused-over hex to class display


  Commit: 5145c9422c2dd26efd9f532f88f99730801c6019
      https://github.com/wesnoth/wesnoth/commit/5145c9422c2dd26efd9f532f88f99730801c6019
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/editor/editor_display.cpp
    M src/game_display.cpp
    M src/game_display.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/tests/utils/fake_display.cpp

  Log Message:
  -----------
  display takes a pointer to whiteboard manager

It uses a shared_ptr, to prevent crashes during play_controller
initialization. But it only holds a weak_ptr, to preserve
previous behavior of skipping whiteboard ops when the ptr is
NULL.

It requires also for us to construct the whiteboard before
constructing the gui, so that we have a valid pointer to pass.

Most likely all of the managers will have to be moved forward,
in this commit we move forward the whiteboard and pathfinding
module, anticipating future commits.


  Commit: 7078dd34e61b18287338e9545575f9cf2dad5b93
      https://github.com/wesnoth/wesnoth/commit/7078dd34e61b18287338e9545575f9cf2dad5b93
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  purge a useless "report()" function in reports.cpp


  Commit: 8faa4bf059f75128e922696905f151d1ba7f7d48
      https://github.com/wesnoth/wesnoth/commit/8faa4bf059f75128e922696905f151d1ba7f7d48
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/reports.cpp
    M src/reports.hpp
    M src/scripting/lua.cpp

  Log Message:
  -----------
  refactor reports to take display_context as an argument


  Commit: f4754496d3ae0eaca9a73b86ff849ba793564ffe
      https://github.com/wesnoth/wesnoth/commit/f4754496d3ae0eaca9a73b86ff849ba793564ffe
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.hpp

  Log Message:
  -----------
  remove unnecessary (duplicated) accessors


  Commit: 2a2a50a1788ba3ced56e2f51a230d0683a21c1f0
      https://github.com/wesnoth/wesnoth/commit/2a2a50a1788ba3ced56e2f51a230d0683a21c1f0
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/play_controller.cpp
    M src/resources.cpp
    M src/resources.hpp

  Log Message:
  -----------
  make whiteboard a shared_pointer in resources

This makes subsequent commit easier, because lua wants to be able
to make reports, and therefore needs a report_context


  Commit: 816be79aa2c48849186edb6c6fff3252b6bdf813
      https://github.com/wesnoth/wesnoth/commit/816be79aa2c48849186edb6c6fff3252b6bdf813
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/reports.cpp
    M src/reports.hpp
    M src/scripting/lua.cpp

  Log Message:
  -----------
  add reports::context structure, and use it for reports


  Commit: dd8e0159f90a115654de4f0612a6917f0ed00c0f
      https://github.com/wesnoth/wesnoth/commit/dd8e0159f90a115654de4f0612a6917f0ed00c0f
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/reports.cpp
    M src/reports.hpp
    M src/scripting/lua.cpp

  Log Message:
  -----------
  add tod manager to report::context

This allows to remove all remaining resources:: links from the
reports generator code, and to finish removing several expensive
dependencies from that compilation unit.


  Commit: 89c22a827982b65d2ccd6c73d758c09d43892730
      https://github.com/wesnoth/wesnoth/commit/89c22a827982b65d2ccd6c73d758c09d43892730
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.hpp
    M src/reports.cpp

  Log Message:
  -----------
  add virtual fcns to display, remove refs to game_display in reports

This commit adds virtual functions covering "observers",
"displayed_unit_hex", and "playing_side", in display:: object.
This allows to avoid dynamic casts in the reports.cpp file, and
to eliminate a header. It avoids the possibility of segfault when
using the editor if the reports context isn't set up correctly.


  Commit: 2c312a11ef02b734cf23ffabccce74b6ea07dee0
      https://github.com/wesnoth/wesnoth/commit/2c312a11ef02b734cf23ffabccce74b6ea07dee0
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-12 (Thu, 12 Jun 2014)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/editor/editor_display.cpp
    M src/game_display.cpp
    M src/game_display.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/reports.cpp
    M src/reports.hpp
    M src/resources.cpp
    M src/resources.hpp
    M src/scripting/lua.cpp
    M src/tests/utils/fake_display.cpp

  Log Message:
  -----------
  Merge branch 'refactor_reports'


Compare: https://github.com/wesnoth/wesnoth/compare/62eb55a5a712...2c312a11ef02