[Commits] [wesnoth/wesnoth] 000c71: fixup 9e7dc5ba008298d823c13cff214f7477601b5efd

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 000c71a2c24b20aac881669ed20d8104a673aedf
      https://github.com/wesnoth/wesnoth/commit/000c71a2c24b20aac881669ed20d8104a673aedf
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-18 (Wed, 18 Jun 2014)

  Changed paths:
    M src/actions/create.cpp

  Log Message:
  -----------
  fixup 9e7dc5ba008298d823c13cff214f7477601b5efd

The scoped_ptr<unit> construct which was used previously in
actions/create.cpp is unnecessary after this commit, and it seems
like it could be related to this error report:

http://wesnoth.org:8080/job/Wesnoth/branch=master,compiler=default,label=Debian7-64/185/consoleText

The most significant change of this commit is that
unit_creator::add_unit now does not make a "temporary" unit
instance from the cfg, and then copy construct it. From source
inspection that step appears to be unnecessary, and it somewhat
obfuscates the meaning of this code in actions/create.cpp


  Commit: 12515a64667913f964fb3eee32d707401c8e445d
      https://github.com/wesnoth/wesnoth/commit/12515a64667913f964fb3eee32d707401c8e445d
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-18 (Wed, 18 Jun 2014)

  Changed paths:
    M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Merge branch 'master' of git://github.com/wesnoth/wesnoth


Compare: https://github.com/wesnoth/wesnoth/compare/9593d10050e5...12515a646679