[Commits] [wesnoth/wesnoth] 8f0fe8: put include guards on boost/function

GitHub noreply at github.com
Thu Jun 19 19:09:14 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8f0fe88635c0a06969b7f49b13e4fb74b066b317
      https://github.com/wesnoth/wesnoth/commit/8f0fe88635c0a06969b7f49b13e4fb74b066b317
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M src/ai/composite/ai.cpp
    M src/ai/composite/property_handler.hpp
    M src/ana/src/asio_server.hpp
    M src/campaign_server/campaign_server.hpp
    M src/display.hpp
    M src/gui/auxiliary/event/dispatcher.hpp
    M src/gui/auxiliary/timer.hpp
    M src/gui/auxiliary/window_builder.hpp
    M src/gui/dialogs/dialog.hpp
    M src/gui/widgets/pane.hpp
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/selectable.hpp
    M src/gui/widgets/settings.hpp
    M src/gui/widgets/text.hpp
    M src/gui/widgets/window.hpp
    M src/playturn_network_adapter.hpp
    M src/random_new_synced.hpp
    M src/server/player_network.hpp
    M src/server/server.hpp
    M src/synced_commands.hpp
    M src/synced_context.hpp
    M src/tests/test_sdl_utils.hpp
    M src/wesmage/filter.cpp
    M src/whiteboard/utility.hpp

  Log Message:
  -----------
  put include guards on boost/function

According to clang boost/function.hpp does not have include guards,
and from inspecting clang diagnostics we include it many times
in several compilation units. This commit adds an external include
guard to all of our includes of this header, it was made using

find . -type f -exec sed -i 's/^#include <boost\/function\.hpp>$/\n#ifndef I

and inspecting the results.


  Commit: c4c69d6d796bcab363555a0e534633a44f5c1af2
      https://github.com/wesnoth/wesnoth/commit/c4c69d6d796bcab363555a0e534633a44f5c1af2
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M src/gui/widgets/helper.cpp
    M src/gui/widgets/helper.hpp

  Log Message:
  -----------
  remove unnecessary include


  Commit: aa999669c174a2a8487eb256d07d423ecb5a59ef
      https://github.com/wesnoth/wesnoth/commit/aa999669c174a2a8487eb256d07d423ecb5a59ef
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-06-19 (Thu, 19 Jun 2014)

  Changed paths:
    M src/ai/composite/ai.cpp
    M src/ai/composite/property_handler.hpp
    M src/ana/src/asio_server.hpp
    M src/campaign_server/campaign_server.hpp
    M src/display.hpp
    M src/gui/auxiliary/event/dispatcher.hpp
    M src/gui/auxiliary/timer.hpp
    M src/gui/auxiliary/window_builder.hpp
    M src/gui/dialogs/dialog.hpp
    M src/gui/widgets/pane.hpp
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/selectable.hpp
    M src/gui/widgets/settings.hpp
    M src/gui/widgets/text.hpp
    M src/gui/widgets/window.hpp
    M src/playturn_network_adapter.hpp
    M src/random_new_synced.hpp
    M src/server/player_network.hpp
    M src/server/server.hpp
    M src/synced_commands.hpp
    M src/synced_context.hpp
    M src/tests/test_sdl_utils.hpp
    M src/wesmage/filter.cpp
    M src/whiteboard/utility.hpp

  Log Message:
  -----------
  Merge branch 'include_guards_on_boost_function'


Compare: https://github.com/wesnoth/wesnoth/compare/184ea58c858e...aa999669c174


More information about the Commits mailing list