[Commits] [wesnoth/wesnoth] 00d7b0: NR: Refactor the White Magi respawn location findi...

GitHub noreply at github.com
Sat Jun 21 14:18:03 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 00d7b06faf87aa265bc483631c6db8a22c846c12
      https://github.com/wesnoth/wesnoth/commit/00d7b06faf87aa265bc483631c6db8a22c846c12
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-21 (Sat, 21 Jun 2014)

  Changed paths:
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg

  Log Message:
  -----------
  NR: Refactor the White Magi respawn location finding code into a macro

This bit was subject to a particularly bad case of code copy-pasting
when the only real variable is the id of the first respawn hub
candidate.

Added a statement to clear the respawn_hub WML variable after running
the code since it's never used again afterwards.


  Commit: 5e57bcaab2b00a6939e9671acac7aa358a96fed0
      https://github.com/wesnoth/wesnoth/commit/5e57bcaab2b00a6939e9671acac7aa358a96fed0
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-21 (Sat, 21 Jun 2014)

  Changed paths:
    M changelog
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg
    M players_changelog

  Log Message:
  -----------
  NR: Search for White Magi respawn locs only within map edges (bug #22097)

Without this, the engine may match map borders and send the respawnee
back to the player's recall list as those count as invalid locations
like "recall","recall".


Compare: https://github.com/wesnoth/wesnoth/compare/87b3ba53771f...5e57bcaab2b0


More information about the Commits mailing list