[Commits] [wesnoth/wesnoth] 786789: campaignd: Log errno to stderr if deleting an add-...

GitHub noreply at github.com
Sat Jun 28 22:17:51 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 786789b2d788d9166acc54e4bcab8f308e303a4a
      https://github.com/wesnoth/wesnoth/commit/786789b2d788d9166acc54e4bcab8f308e303a4a
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-06-28 (Sat, 28 Jun 2014)

  Changed paths:
    M src/campaign_server/campaign_server.cpp

  Log Message:
  -----------
  campaignd: Log errno to stderr if deleting an add-on archive failed

Unhandled remove() return value issue found by coverity.

This is about the most we can do about this here since internal server
errors like this shouldn't matter to clients (remove() failing is only
an issue if write_config() somehow fails or the same add-on is
reuploaded later).

Note to self: sanitize campaignd logging later so we can actually
distinguish between informational and error messages without including
the word "error" or "failure" and variations thereof in each line.





More information about the Commits mailing list