[Commits] [wesnoth/wesnoth] 2147bb: Use blit_surface() instead of SDL_BlitSurface() in...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2147bb3c54f9390de79fa19657874701585fa029
      https://github.com/wesnoth/wesnoth/commit/2147bb3c54f9390de79fa19657874701585fa029
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-03-07 (Fri, 07 Mar 2014)

  Changed paths:
    M changelog
    M src/image_modifications.cpp

  Log Message:
  -----------
  Use blit_surface() instead of SDL_BlitSurface() in the ~BG() implementation

For some reason, ~BG() used SDL_BlitSurface() directly instead of using
the alternate blit_surface() implementation, unlike every other image
path function type in existence that needs to do blitting.

This works the first time when scaling or cropping an image (say,
"misc/blank-hex.png~BG()~CROP(0,0,34,34)"), but the second time it's
used with different scaling/cropping parameters, it yields the result it
would without ~BG() in the pipeline. This is somehow remedied by this
change, and I don't see any potential issues arising from it anyway
(save for a negligible performance impact on ~BG(), maybe).