[Commits] [wesnoth/wesnoth] 690fb0: Fix using an uninitialised value.

GitHub noreply at github.com
Sat Mar 8 11:47:59 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 690fb03aac04d72e44842c9569e99fbd904a2df1
      https://github.com/wesnoth/wesnoth/commit/690fb03aac04d72e44842c9569e99fbd904a2df1
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Fix using an uninitialised value.

While using valgrind to investigate bug #20876 it warned about this
issue.

Ported from a6eeac04e5dc863013fa3e5e0b723825ddc4fc08


  Commit: e65120075ea292252a016bb19027bfb8ea1d39cc
      https://github.com/wesnoth/wesnoth/commit/e65120075ea292252a016bb19027bfb8ea1d39cc
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/image_modifications.cpp

  Log Message:
  -----------
  Make sure cut_surface gets a neutral surface.

Also change its return to an optimised surface. Fixes bug #20876.

>From the comment added to the source:
Unlike other image functions cut_surface does not convert the input
surface to a neutral surface, nor does it convert its return surface
to an optimised surface.

Since it seems to work for most cases, rather change this caller instead
of the function signature. (The issue was discovered in bug #20876).


  Commit: 65a97dc5255a32184c7a4db836ffdb17d1157bca
      https://github.com/wesnoth/wesnoth/commit/65a97dc5255a32184c7a4db836ffdb17d1157bca
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M changelog

  Log Message:
  -----------
  Update changelog.


Compare: https://github.com/wesnoth/wesnoth/compare/778955501ae4...65a97dc5255a


More information about the Commits mailing list