[Commits] [wesnoth/wesnoth] c293e2: fs: Fix relative directory creation incongruity wi...

GitHub noreply at github.com
Sun Nov 9 22:06:21 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c293e20d25dcb12469a0b0d3eb5a17135b0c95c9
      https://github.com/wesnoth/wesnoth/commit/c293e20d25dcb12469a0b0d3eb5a17135b0c95c9
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-11-09 (Sun, 09 Nov 2014)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fs: Fix relative directory creation incongruity with Boost.filesystem

The non-BFS version of create_directory_if_missing_recursive() handles
relative path names (e.g. "foo") correctly and doesn't attempt to create
a parent that is left unspecified in the path (i.e. empty), but the BFS
version does, predictably failing the whole operation.

This fixes an issue where `./wesnoth -p data foo` from the source tree
would fail with `error filesystem: Could not create parents to foo` if
`foo` did not already exist, when using the Boost.filesystem-based
implementation. `./wesnoth -p data ./foo` would succeed because there is
a visible parent directory '.' that already exists and needs not be
created again.





More information about the Commits mailing list