[Commits] [wesnoth/wesnoth] a7ceb2: rename variable_info_3 -> variable_info

GitHub noreply at github.com
Tue Nov 11 19:51:52 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a7ceb23eb2adeed96a39e8c89c5fcfe229515031
      https://github.com/wesnoth/wesnoth/commit/a7ceb23eb2adeed96a39e8c89c5fcfe229515031
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-11 (Tue, 11 Nov 2014)

  Changed paths:
    M src/variable_info.cpp
    M src/variable_info.hpp
    M src/variable_info_detail.hpp

  Log Message:
  -----------
  rename variable_info_3 -> variable_info

the only reason thart this was called variable_info_3 is that it was my
third try to implement it (my second try that used boost::variant for
the differnet states turned out to be too slow)


  Commit: 73b523a077ead06f3bcc89961955a4560b3a4ceb
      https://github.com/wesnoth/wesnoth/commit/73b523a077ead06f3bcc89961955a4560b3a4ceb
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-11 (Tue, 11 Nov 2014)

  Changed paths:
    M src/variable_info.cpp

  Log Message:
  -----------
  refactor variable_info.cpp

this is a strict refactor which shouldn't change the compiled code.


  Commit: f777c3ce186758ddc771fd4148fbd455f1533d49
      https://github.com/wesnoth/wesnoth/commit/f777c3ce186758ddc771fd4148fbd455f1533d49
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-11 (Tue, 11 Nov 2014)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  get rid of preprocessor conditional

having 2 different implementations (one for c++11 and one for c++03)
makes the code harder to maintain.


Compare: https://github.com/wesnoth/wesnoth/compare/19caaa667a64...f777c3ce1867


More information about the Commits mailing list