[Commits] [wesnoth/wesnoth] 622d4c: fix config::get_diff

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 622d4c1313c42c971bf23e438077b699386c71e4
      https://github.com/wesnoth/wesnoth/commit/622d4c1313c42c971bf23e438077b699386c71e4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-15 (Sat, 15 Nov 2014)

  Changed paths:
    M src/config.cpp

  Log Message:
  -----------
  fix config::get_diff


  Commit: ec1e0f22f2001976b4143710f28fbc703fba0cc1
      https://github.com/wesnoth/wesnoth/commit/ec1e0f22f2001976b4143710f28fbc703fba0cc1
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-15 (Sat, 15 Nov 2014)

  Changed paths:
    M src/server/game.cpp

  Log Message:
  -----------
  use sides_.size() instead of MAX_PLAYES

we usualy want to use that number to index the sides_ vector so
comparing against sides_.size() makes more sense.
We now also use side_index for the index of the side in sides_ and
side_num for the value of side_cfg["side"]
I also put some additional checks.


  Commit: e5c5839109cf29f2cd597c483427fecd382f7a0a
      https://github.com/wesnoth/wesnoth/commit/e5c5839109cf29f2cd597c483427fecd382f7a0a
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-15 (Sat, 15 Nov 2014)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  limit variable scopes

knowing that those varaiables aren't used later down makdes the code
easier to understand.


  Commit: 8c9a738b54ea87105516d41bfd00d2ac946c6219
      https://github.com/wesnoth/wesnoth/commit/8c9a738b54ea87105516d41bfd00d2ac946c6219
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-15 (Sat, 15 Nov 2014)

  Changed paths:
    M src/game_initialization/multiplayer_connect.cpp

  Log Message:
  -----------
  don't limit gold and income in mpconnect if not neeeded

partly fixes http://gna.org/bugs/?22485.


  Commit: 113c8d8504cc0432b4ba063ae076e9a0107477d3
      https://github.com/wesnoth/wesnoth/commit/113c8d8504cc0432b4ba063ae076e9a0107477d3
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-15 (Sat, 15 Nov 2014)

  Changed paths:
    M src/config.cpp

  Log Message:
  -----------
  don't print blank attribute values

blank values have no string representation, the are more temporary
values created becasue someone wanted to put something in them but then
thought different.

writing and reading them caused then to be converted to empty string
values which is something diffrerent.


Compare: https://github.com/wesnoth/wesnoth/compare/fd9bfbc42dd4...113c8d8504cc