[Commits] [wesnoth/wesnoth] f6065d: don't limit server max sides

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f6065d3da93936dc269e70ec08c9e5ea82b2a68f
      https://github.com/wesnoth/wesnoth/commit/f6065d3da93936dc269e70ec08c9e5ea82b2a68f
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-16 (Sun, 16 Nov 2014)

  Changed paths:
    M src/server/game.cpp
    M src/server/game.hpp
    M src/server/server.cpp

  Log Message:
  -----------
  don't limit server max sides

there are 2 reasons why the maximum side number is limited in some
contexts:
1) The map format can only store 9 starting positions
2) only the first 9 sides have default colors.

However, 'color' and 'starting position' are both sideproperties that
can explicitly given by wml if needed. And the server doesn't use any of
them, so i see no reason why the server should reject those games.


  Commit: 10b2c0d9beb5ab9710128fe2a47f5515584971ce
      https://github.com/wesnoth/wesnoth/commit/10b2c0d9beb5ab9710128fe2a47f5515584971ce
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-16 (Sun, 16 Nov 2014)

  Changed paths:
    M src/game_initialization/connect_engine.cpp

  Log Message:
  -----------
  fix mp connect colors

i actualy didnt test whether this casues bugs. But we use color to set
the value of combo_color_ combobox which has only MAX_PLAYER number of
options.


  Commit: a53594b2b19723db348ad8ccd1db9318e7bba37b
      https://github.com/wesnoth/wesnoth/commit/a53594b2b19723db348ad8ccd1db9318e7bba37b
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2014-11-16 (Sun, 16 Nov 2014)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  remove outcommented code


  Commit: 50d2b133ec3af33e0c126a697e1e313ccccfc002
      https://github.com/wesnoth/wesnoth/commit/50d2b133ec3af33e0c126a697e1e313ccccfc002
  Author: gfgtdf <tischpapier at gmail.com>
  Date:   2014-11-16 (Sun, 16 Nov 2014)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/server/game.cpp
    M src/server/game.hpp
    M src/server/server.cpp

  Log Message:
  -----------
  Merge pull request #333 from gfgtdf/wesnothd_sides

don't limit server max sides


Compare: https://github.com/wesnoth/wesnoth/compare/7c71f81ed0ea...50d2b133ec3a