[Commits] [wesnoth/wesnoth] 2cb85b: fix an uncaught bad lexical cast exception

GitHub noreply at github.com
Tue Nov 18 01:17:38 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2cb85bd161d30f64a453d2280adee4785fcf1eca
      https://github.com/wesnoth/wesnoth/commit/2cb85bd161d30f64a453d2280adee4785fcf1eca
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/server/player.cpp

  Log Message:
  -----------
  fix an uncaught bad lexical cast exception

coverity reports that it is uncaught and would therefore crash
the server if it occurred


  Commit: bb9aabd1b8b4858827da27d2193e6f9cad1c3c81
      https://github.com/wesnoth/wesnoth/commit/bb9aabd1b8b4858827da27d2193e6f9cad1c3c81
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/server/game.cpp
    M src/server/room_manager.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  replace many lexical_cast with lexical_cast_default

This is to avoid bad_lexical_cast exception. I'm not sure if in
any cases this could actually have thrown but it's better to be
safe.

Conflicts:
	src/server/game.cpp


  Commit: 8f9f3dd6f56c15d12cc80e220382ebd0d1562edb
      https://github.com/wesnoth/wesnoth/commit/8f9f3dd6f56c15d12cc80e220382ebd0d1562edb
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  catch boost::bad_function_call exceptions in server command handler

Don't know if this can actually happen in practice but it is
reported by coverity.


  Commit: d45d8ad8906848455666220012c4cb28765d3f6c
      https://github.com/wesnoth/wesnoth/commit/d45d8ad8906848455666220012c4cb28765d3f6c
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/server/ban.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  backport: change server to use utf8 instead of utils unicode

This is to make it easier to cherry-pick the exception catch fixups


  Commit: 1bc5aa91fb8f485e3352306af3a8fd46861b2be7
      https://github.com/wesnoth/wesnoth/commit/1bc5aa91fb8f485e3352306af3a8fd46861b2be7
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/server/ban.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  server: catch invalid utf8 exceptions

issue reported by coverity


Compare: https://github.com/wesnoth/wesnoth/compare/5aa1e9c40a1e...1bc5aa91fb8f


More information about the Commits mailing list