[Commits] [wesnoth/wesnoth] 889eb5: wmllint: fixed a bug in spellchecking caused by Py...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 889eb5aa7b0e7ed0cee05ebe85779aaa7bf0424d
      https://github.com/wesnoth/wesnoth/commit/889eb5aa7b0e7ed0cee05ebe85779aaa7bf0424d
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wmllint

  Log Message:
  -----------
  wmllint: fixed a bug in spellchecking caused by Python 3 map()

This bug prevented local spelling words from being added to the spellchecking dictionary, and it was caused by the fact that the map iterator was never iterated.
Replaced with an explicit for cycle.


  Commit: bb51399d26be56a9d7769b332ea43d63c70ab173
      https://github.com/wesnoth/wesnoth/commit/bb51399d26be56a9d7769b332ea43d63c70ab173
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: shorten code by using sorted() instead of .sort()


  Commit: 032609e7821fe74177e0add525e7a5987bdd206f
      https://github.com/wesnoth/wesnoth/commit/032609e7821fe74177e0add525e7a5987bdd206f
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wmlscope

  Log Message:
  -----------
  wmlscope: clearer message when checking for duplicated files

For now, I'm keeping the MD5 hashes in the message.


  Commit: c407625ad3c6d101c71def76cdd66b2be0278452
      https://github.com/wesnoth/wesnoth/commit/c407625ad3c6d101c71def76cdd66b2be0278452
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wmllint

  Log Message:
  -----------
  wmllint: fixed .keys() usages for Python 3

In most cases, calls to the .keys() method were unnecessary, because they were used to test if a dictionary has a key; this can be done by simply using the 'in' operator on the dictionary itself.


  Commit: be62976d80b77a701214b64b6b499bc7f6288778
      https://github.com/wesnoth/wesnoth/commit/be62976d80b77a701214b64b6b499bc7f6288778
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py
    M data/tools/wmlscope

  Log Message:
  -----------
  wmltools and wmlscope: fixed .keys() usages for Python 3

Most usages of the .keys() method were already safe, because they were either iterated only once, or they were wrapped in a call to sorted(), which casts them as lists


  Commit: 4d675c377f039181338bc95f2264905514c1ed25
      https://github.com/wesnoth/wesnoth/commit/4d675c377f039181338bc95f2264905514c1ed25
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-06 (Thu, 06 Aug 2015)

  Changed paths:
    M data/tools/wesnoth/wmliterator.py
    M data/tools/wesnoth/wmltools.py
    M data/tools/wmlindent
    M data/tools/wmllint
    M data/tools/wmlscope

  Log Message:
  -----------
  All main wml tools: used Python 3 floating point division

wmltools required integer division, so here the corresponding operator (//) is used


  Commit: 63863d9f2fc14732746fc74ac214864d6d1a12f6
      https://github.com/wesnoth/wesnoth/commit/63863d9f2fc14732746fc74ac214864d6d1a12f6
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-07 (Fri, 07 Aug 2015)

  Changed paths:
    M data/tools/wmlscope

  Log Message:
  -----------
  wmlscope: enabled image size checks

The undersized() function is supposed to warn if an image has a size below 60 x 60 pixels. I didn't manage to find any documentation about why it was commented out.
I also replaced the error message printed if the PIL library is missing with one more verbose and updated.


  Commit: 2559f9706377a84d8bb819c42f9f785981f9a753
      https://github.com/wesnoth/wesnoth/commit/2559f9706377a84d8bb819c42f9f785981f9a753
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-08-07 (Fri, 07 Aug 2015)

  Changed paths:
    M data/tools/wmlscope

  Log Message:
  -----------
  wmlscope: slightly improved percentage output when checking for untyped formals


Compare: https://github.com/wesnoth/wesnoth/compare/4e4fdd0504b9...2559f9706377