[Commits] [wesnoth/wesnoth] 079692: Clarify false default of [terrain_mask] border= as...

GitHub noreply at github.com
Thu Aug 13 23:11:41 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 079692d42457a7b9251bfe319a65d8341217d0b7
      https://github.com/wesnoth/wesnoth/commit/079692d42457a7b9251bfe319a65d8341217d0b7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2015-08-14 (Fri, 14 Aug 2015)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Clarify false default of [terrain_mask] border= as expected

The wiki states this is supposed to be false. gamemap::overlay already gives border=
a default false value, but this clarifies the value, code-wise.


  Commit: e9d70dbc1ededf857e5b15735115a675d95e53bd
      https://github.com/wesnoth/wesnoth/commit/e9d70dbc1ededf857e5b15735115a675d95e53bd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2015-08-14 (Fri, 14 Aug 2015)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Default [object] silent= to true if no description is provided

Code snippet by shadowm


  Commit: 730d83729687f7107bc68582686ccdf0720b7b42
      https://github.com/wesnoth/wesnoth/commit/730d83729687f7107bc68582686ccdf0720b7b42
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2015-08-14 (Fri, 14 Aug 2015)

  Changed paths:
    M src/map.cpp
    M src/map.hpp

  Log Message:
  -----------
  Drop redundant border_size argument from gamemap::write

This was rendered unnecessary in in2f650419dad963f7ad as the gamemap namespace already has
border_size_ assigned to gamemap::default_border, and 6b78073b49bcebf00b removed the passing
of any other value


Compare: https://github.com/wesnoth/wesnoth/compare/fcf8b72efd31...730d83729687


More information about the Commits mailing list