[Commits] [wesnoth/wesnoth] 719914: replace all '_' with spaces in event names

GitHub noreply at github.com
Sun Dec 20 21:11:55 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7199146978b2844e3e14210f74afd67b9e522832
      https://github.com/wesnoth/wesnoth/commit/7199146978b2844e3e14210f74afd67b9e522832
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-12-20 (Sun, 20 Dec 2015)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/move.cpp
    M src/game_events/menu_item.cpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  replace all '_' with spaces in event names

This incnsitency was confusing, i choose to use spaces becasue thats
what most event names used.


  Commit: d02f76e3c0e4f5036944919034f745b24fd6ecc4
      https://github.com/wesnoth/wesnoth/commit/d02f76e3c0e4f5036944919034f745b24fd6ecc4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-12-20 (Sun, 20 Dec 2015)

  Changed paths:
    M src/gui/dialogs/game_load.cpp

  Log Message:
  -----------
  disable show replay for start-of-scenario saves

This also disables 'cancel orders' for those saves.

Actually 'show replay' should also be disabled when loading the save via
mp load game dialog, but implementing that would be wasted time if we
decide to support replays in map some time.


  Commit: ad424f8c0342dfaf59f59c3adc0127ecc6da06d0
      https://github.com/wesnoth/wesnoth/commit/ad424f8c0342dfaf59f59c3adc0127ecc6da06d0
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-12-20 (Sun, 20 Dec 2015)

  Changed paths:
    M src/unit.cpp

  Log Message:
  -----------
  remove duration='turn_end' ('turn end' still works)

'turn end' did exactly the same. So we we basicalls did this work twice.
'expire_modifications' is not a cheap taks because it needs to check
every modification in every unit.


Compare: https://github.com/wesnoth/wesnoth/compare/5d390d4de13a...ad424f8c0342


More information about the Commits mailing list