[Commits] [wesnoth/wesnoth] 256c82: fix assertion failure on 'update shroud now'

GitHub noreply at github.com
Mon Feb 23 18:03:02 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 256c82f22d3667595da4cd4ee5495157c2515f5f
      https://github.com/wesnoth/wesnoth/commit/256c82f22d3667595da4cd4ee5495157c2515f5f
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-23 (Mon, 23 Feb 2015)

  Changed paths:
    M src/menu_events.cpp
    M src/synced_commands.cpp

  Log Message:
  -----------
  fix assertion failure on 'update shroud now'


  Commit: 730dcfdd0b983b84d55f8ab4cb8c52bc03212b73
      https://github.com/wesnoth/wesnoth/commit/730dcfdd0b983b84d55f8ab4cb8c52bc03212b73
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-23 (Mon, 23 Feb 2015)

  Changed paths:
    M src/menu_events.cpp
    M src/synced_commands.cpp

  Log Message:
  -----------
  fix OOS when undoing after deactivating DSU

previously the 'auto_shroud' replay action also casued the shroud to be
updated (resources::undo_stack->commit_vision()), this caused bugs
becasue it added 2 entries on the undo stack, which caused 2 actionas to
be removed from the replay when undoing after deacticvating delayed
shroud updates.

Also there was no need to do resources::undo_stack->commit_vision(); on
'auto_shroud' replay command becasue we usually automaticly put a
'update_shroud'  command before every 'auto_shroud' command.


  Commit: 41c7d165054fc64c53b3fbc09fd427c55e06cec5
      https://github.com/wesnoth/wesnoth/commit/41c7d165054fc64c53b3fbc09fd427c55e06cec5
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-23 (Mon, 23 Feb 2015)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp

  Log Message:
  -----------
  fix assertion failure when undoing after toggeling DSU

fix up my previous commit "fix OOS when undoing after deactivating DSU"


Compare: https://github.com/wesnoth/wesnoth/compare/8ce430da2717...41c7d165054f


More information about the Commits mailing list