[Commits] [wesnoth/wesnoth] 0866cc: remove some end_check_level()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0866ccb4d461e39ee54f47dad5fca6a9d261a1f7
      https://github.com/wesnoth/wesnoth/commit/0866ccb4d461e39ee54f47dad5fca6a9d261a1f7
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  remove some end_check_level()

we already call check_victory which calls end_check_level() at the end of any synced context so there is no need to do this.

I suppose i was just cautious when i replaced the  calls to check_victory with them in https://github.com/wesnoth/wesnoth/commit/d1d70cb7b1ed02b9888d21f0008edd51d7ba57d4


  Commit: 425125250649e608484fc8f92f5c036081344d1e
      https://github.com/wesnoth/wesnoth/commit/425125250649e608484fc8f92f5c036081344d1e
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M src/ai/actions.cpp
    M src/ai/manager.cpp
    M src/game_end_exceptions.hpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/replay_controller.cpp
    M src/synced_context.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/side_actions.cpp

  Log Message:
  -----------
  refactor end_turn_exception

end_turn_exception was split into 2 exceptions.
restart_turn_exception/struct which is used when a side got reassigned
this case covers most of end_turn_exceptions previous usecases.
and ai_end_turn_exception which is only used by the ai internally, we
also move the throwing of ai_end_turn_exception fom
playsingle/mp_controller::handle_generic_event to
ai::action_result::execute so that non ai code that might call
handle_generic_event doesn't have to think about ai_end_turn_exception.

This also partly fixes a bug where undroiding a side caused the sides turn to end.


  Commit: f16a0f6e6199004181042c1b5270e6bb9b6b3a0c
      https://github.com/wesnoth/wesnoth/commit/f16a0f6e6199004181042c1b5270e6bb9b6b3a0c
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  add comment


  Commit: 781df37ca4afa6faf85caa8d917943c989e569e8
      https://github.com/wesnoth/wesnoth/commit/781df37ca4afa6faf85caa8d917943c989e569e8
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    A src/countdown_clock.cpp
    A src/countdown_clock.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp

  Log Message:
  -----------
  move mp countdown code to new class


Compare: https://github.com/wesnoth/wesnoth/compare/cc1eab124507...781df37ca4af