[Commits] [wesnoth/wesnoth] dbb75b: add oos debug mode and mp_debug_checkup class

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dbb75bdd478699e86b6122525e695019f5e458b1
      https://github.com/wesnoth/wesnoth/commit/dbb75bdd478699e86b6122525e695019f5e458b1
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-01-08 (Thu, 08 Jan 2015)

  Changed paths:
    M src/game_classification.cpp
    M src/game_classification.hpp
    M src/synced_checkup.cpp
    M src/synced_checkup.hpp
    M src/synced_context.cpp
    M src/synced_context.hpp

  Log Message:
  -----------
  add oos debug mode and mp_debug_checkup class

The game sometimes does some checkup to test whether the calculated results in a replay match the ones calculated during the original game.
This data was stored in the replay inside the [command] for that action. The problem is that this doesn't work in networked mp because we often send the [command] before calculating the results.
I added an alternative mode that used get_user_choice to compare the results, this also works in networked mp but it causes a little more network traffic.


  Commit: e2a52ee0cbfe3d45b9203e134fb56cc7e3019f7d
      https://github.com/wesnoth/wesnoth/commit/e2a52ee0cbfe3d45b9203e134fb56cc7e3019f7d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-01-08 (Thu, 08 Jan 2015)

  Changed paths:
    M src/game_initialization/configure_engine.cpp
    M src/game_initialization/configure_engine.hpp
    M src/game_initialization/multiplayer_configure.cpp
    M src/game_initialization/multiplayer_configure.hpp

  Log Message:
  -----------
  add OOS debug option in mp configure


  Commit: db5f6daec3bc7b7859a2592f057f91c4e6ef6854
      https://github.com/wesnoth/wesnoth/commit/db5f6daec3bc7b7859a2592f057f91c4e6ef6854
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-01-08 (Thu, 08 Jan 2015)

  Changed paths:
    M src/game_initialization/connect_engine.cpp

  Log Message:
  -----------
  don't assign computer sides to new players

seems like that part of bug https://gna.org/bugs/?22968 effected 1.13 too.


Compare: https://github.com/wesnoth/wesnoth/compare/5067ecf932ff...db5f6daec3bc