[Commits] [wesnoth/wesnoth] 6c483d: Use prefix instead of postfix increment/decrement

GitHub noreply at github.com
Tue Jul 7 02:02:22 UTC 2015


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6c483d767c96e5d55e810690c519c94398172095
      https://github.com/wesnoth/wesnoth/commit/6c483d767c96e5d55e810690c519c94398172095
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/ai/lua/core.cpp

  Log Message:
  -----------
  Use prefix instead of postfix increment/decrement

Found by cppcheck.


  Commit: c534c6156f39714431f16b3013e65c59e660c62c
      https://github.com/wesnoth/wesnoth/commit/c534c6156f39714431f16b3013e65c59e660c62c
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/gettext_boost.cpp

  Log Message:
  -----------
  i18n: Use ctor initialization list instead of statement in ctor body

Found by cppcheck.


  Commit: 954260041358a6c27e176e116176462051df5ccb
      https://github.com/wesnoth/wesnoth/commit/954260041358a6c27e176e116176462051df5ccb
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/gui/widgets/list.cpp

  Log Message:
  -----------
  gui2: Initialize variables

Found by cppcheck.


  Commit: 83fad139731694111be923051f45facd6e79f908
      https://github.com/wesnoth/wesnoth/commit/83fad139731694111be923051f45facd6e79f908
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Use empty() method instead of inefficient size() checks on linked lists

Found by cppcheck.


  Commit: bf83aecd08274cd6dfe1231dfcc8b59fb888157a
      https://github.com/wesnoth/wesnoth/commit/bf83aecd08274cd6dfe1231dfcc8b59fb888157a
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/playturn_network_adapter.cpp

  Log Message:
  -----------
  Use prefix instead of postfix increment/decrement

Found by cppcheck.


  Commit: cfdeac8b6a3b86c3dd4acdfcb33ecea37a8d4e1f
      https://github.com/wesnoth/wesnoth/commit/cfdeac8b6a3b86c3dd4acdfcb33ecea37a8d4e1f
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/scripting/lua.cpp

  Log Message:
  -----------
  Use prefix instead of postfix increment/decrement

Found by cppcheck.


  Commit: 40eee388b0291174705f3903e7ff355f9a08c912
      https://github.com/wesnoth/wesnoth/commit/40eee388b0291174705f3903e7ff355f9a08c912
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/show_dialog.cpp

  Log Message:
  -----------
  gui1: Elide pointless assignment

Found by cppcheck.


  Commit: 390c93a191f70cd04953c1750cae2b6002a30f9b
      https://github.com/wesnoth/wesnoth/commit/390c93a191f70cd04953c1750cae2b6002a30f9b
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-07-06 (Mon, 06 Jul 2015)

  Changed paths:
    M src/strftime.cpp

  Log Message:
  -----------
  Fix end iterator dereference with specific util::strftime() input

A format string with a trailing '%' character at the end would cause an
implementation detail to dereference the end iterator of a string. Since
the underlying storage is a null-terminated string, this would be
harmless in practice.

Found by cppcheck.


Compare: https://github.com/wesnoth/wesnoth/compare/0c6482b7db0c...390c93a191f7


More information about the Commits mailing list