[Commits] [wesnoth/wesnoth] 0b5e0b: More spmp fixes

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0b5e0b42c5f3eac47d4d0dd3e23ac0df5a430cf3
      https://github.com/wesnoth/wesnoth/commit/0b5e0b42c5f3eac47d4d0dd3e23ac0df5a430cf3
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M src/game_classification.cpp
    M src/game_classification.hpp
    M src/game_initialization/configure_engine.cpp
    M src/game_initialization/multiplayer_wait.cpp
    M src/game_launcher.cpp
    M src/saved_game.cpp
    M src/settings.cpp
    M src/settings.hpp

  Log Message:
  -----------
  More spmp fixes

refactors out common expressions
game_classification::get_tagname/is_normal_mp_game()

Change some mp_configure defaults from mp campaigns to match the
defaults of sp campaigns (note that since campaigns have
force_lock_settings=yes by default this does not really matter)

Also we simplify how mp_wait reloads the game config.


  Commit: 1cbde8d0d3faa3f5dd54e0b1c4ea721921289853
      https://github.com/wesnoth/wesnoth/commit/1cbde8d0d3faa3f5dd54e0b1c4ea721921289853
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  simplify wesnoth.set_next_scenario and wesnoth.set_end_campaign_credits

luaL_checkstring never returns NULL so we can skip this check.


  Commit: 7df9c043d09f0656d99330d1db92cbe4848646ba
      https://github.com/wesnoth/wesnoth/commit/7df9c043d09f0656d99330d1db92cbe4848646ba
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M src/game_classification.cpp
    M src/game_config_manager.cpp

  Log Message:
  -----------
  don't convert [scenario] to [multiplayer]

This should fix the :cl list which previously did not show all scenarios.

Also it speeds up config reloading becasue previously the contents of every [scenario] were copied multiple times when reloading the game config.

I don't know why the [scenario]s were converted to [multiplayer] in the first place.


  Commit: 1dabbc31636f92bb99fbb35d8be4f00807701172
      https://github.com/wesnoth/wesnoth/commit/1dabbc31636f92bb99fbb35d8be4f00807701172
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-07-21 (Tue, 21 Jul 2015)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  fix play_controller::all_players()


Compare: https://github.com/wesnoth/wesnoth/compare/76f1e4bf3c59...1dabbc31636f