[Commits] [wesnoth/wesnoth] 3799f1: wmltools: Use string.ascii_lowercase for the alpha...

GitHub noreply at github.com
Mon Jul 27 08:47:10 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3799f1e17cf5ec5ab1492c6cb560f988278fef0a
      https://github.com/wesnoth/wesnoth/commit/3799f1e17cf5ec5ab1492c6cb560f988278fef0a
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: Use string.ascii_lowercase for the alphabet


  Commit: 63132099a7e6e8c28923f8a28be4e34fa40891e0
      https://github.com/wesnoth/wesnoth/commit/63132099a7e6e8c28923f8a28be4e34fa40891e0
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: Use collections.defaultdict

And minor nearby whitespace fixes.


  Commit: 817511f7ab59d79890acf4373e064b3b5cade473
      https://github.com/wesnoth/wesnoth/commit/817511f7ab59d79890acf4373e064b3b5cade473
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmlgrammar.py

  Log Message:
  -----------
  wmlgrammar: Various cleanup

* Fix lots of spacing to be PEP8 compliant
* Use collections.defaultdict to simplify some code
* Use dict.get() to simplify some code
* Use plain set() to create a new set
* Don't create unnecessary tuples for string formatting


  Commit: 1ea58864cfb0b7b53790175529426ac90f1f65ba
      https://github.com/wesnoth/wesnoth/commit/1ea58864cfb0b7b53790175529426ac90f1f65ba
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: Consistently use "is" when checking if a variable is None


  Commit: de864c0bc002ddc0b451d4f8ad296ef4bfa949ac
      https://github.com/wesnoth/wesnoth/commit/de864c0bc002ddc0b451d4f8ad296ef4bfa949ac
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  wmltools: Use isinstance to check if a variable is a string

Using the built-in basestring.


  Commit: bd23c32d640fcbd9cfca70b2af8d7aef279299c5
      https://github.com/wesnoth/wesnoth/commit/bd23c32d640fcbd9cfca70b2af8d7aef279299c5
  Author: Kunal Mehta <legoktm at gmail.com>
  Date:   2015-07-26 (Sun, 26 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmliterator.py

  Log Message:
  -----------
  Optimize wmliterator.isDirective()

Skips an unecessary for loop and if conditional.


  Commit: 1599f62f46bad9bf969644d9e6270143269287b4
      https://github.com/wesnoth/wesnoth/commit/1599f62f46bad9bf969644d9e6270143269287b4
  Author: Elvish-Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-07-27 (Mon, 27 Jul 2015)

  Changed paths:
    M data/tools/wesnoth/wmlgrammar.py
    M data/tools/wesnoth/wmliterator.py
    M data/tools/wesnoth/wmltools.py

  Log Message:
  -----------
  Merge pull request #427 from legoktm/wmltools-cleanup

Various Python cleanup in wmltools-related code


Compare: https://github.com/wesnoth/wesnoth/compare/da6e14910066...1599f62f46ba


More information about the Commits mailing list