[Commits] [wesnoth/wesnoth] e2df19: veryfy that synced user commands come from the cor...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e2df198e5545082b8215e9ec13eb7aa98b2e1abc
      https://github.com/wesnoth/wesnoth/commit/e2df198e5545082b8215e9ec13eb7aa98b2e1abc
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-06-08 (Mon, 08 Jun 2015)

  Changed paths:
    M src/replay.cpp

  Log Message:
  -----------
  veryfy that synced user commands come from the correct client

Previously it was possible that (modified) clients send user commands
like recruit or move while its not their turn. To prevent this, we now
use the from_side check (that was previously only used for dependent
commands) also for normal synced commands.

The from_side check works like this:
The sending clients adds a from_side= attribute to its commands which
contains which side issued this command.
The server veryfies that that client actually controls that side
The recieveing clients veryfy that this is the side that can currently
issue commands (the currently plaing side).

For compability with older clients  it currently just gives a
ERR_REPLAY. Later it should be changed into a replay::process_error.