[Commits] [wesnoth/wesnoth] 1b239a: Added a new unit test for [role]

GitHub noreply at github.com
Mon Jun 15 09:30:23 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1b239aa3e6b7fc22be2a54238ec5ac9468afc5d2
      https://github.com/wesnoth/wesnoth/commit/1b239aa3e6b7fc22be2a54238ec5ac9468afc5d2
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    A data/test/scenarios/test_role_types.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Added a new unit test for [role]


  Commit: 787bd1b9c538c73433c23d0ec52676bcbfa2a052
      https://github.com/wesnoth/wesnoth/commit/787bd1b9c538c73433c23d0ec52676bcbfa2a052
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    M data/lua/wml-tags.lua
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Moved [role] to Lua

This fixes indirectly bug #23630


  Commit: 79d44d048619348b662cb371dcfe391ba81c1c1d
      https://github.com/wesnoth/wesnoth/commit/79d44d048619348b662cb371dcfe391ba81c1c1d
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-06-13 (Sat, 13 Jun 2015)

  Changed paths:
    M data/lua/wml-tags.lua

  Log Message:
  -----------
  Bugfixes in [role] tag

The following fixes were applied:
* cfg.__shallow_literal -> helper.shallow_literal, to allow calling the tag
  from Lua as wesnoth.wml_actions.role
* added trim() to the for cycle
* deleted filter.role and filter.type after having copied their data, because
  when calling the tag from Lua they ended up being deleted too early
* unit.role = cfg.role -> unit.role = role


  Commit: d4a3c764472d7b7ae785260ca9f1ac9f166de9ff
      https://github.com/wesnoth/wesnoth/commit/d4a3c764472d7b7ae785260ca9f1ac9f166de9ff
  Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-06-13 (Sat, 13 Jun 2015)

  Changed paths:
    M data/test/scenarios/test_role_types.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Improved the [role] unit test

A new unit test, called 'test_role_lua' was added, to ensure that the [role]
tag could be used from Lua.
Also, in the first unit test the types list is stored in a variable, to
ensure that variable substitution works as intended


  Commit: e79e86c5807bfb72f54a47d15e28e29d0f9fa700
      https://github.com/wesnoth/wesnoth/commit/e79e86c5807bfb72f54a47d15e28e29d0f9fa700
  Author: Elvish-Hunter <elvish.hunter2010 at gmail.com>
  Date:   2015-06-15 (Mon, 15 Jun 2015)

  Changed paths:
    M data/lua/wml-tags.lua
    A data/test/scenarios/test_role_types.cfg
    M src/game_events/action_wml.cpp
    M wml_test_schedule

  Log Message:
  -----------
  Merge pull request #410 from Elvish-Hunter/master

Move [role] to lua (fix for bug #23630)


Compare: https://github.com/wesnoth/wesnoth/compare/e377f2912567...e79e86c5807b


More information about the Commits mailing list