[Commits] [wesnoth/wesnoth] b2738f: Use looks_like_pbl() to disallow .pbl file inclusi...

GitHub noreply at github.com
Wed Jun 17 02:24:56 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b2738ffb2fdd2550ececb74f76f75583c43c8b59
      https://github.com/wesnoth/wesnoth/commit/b2738ffb2fdd2550ececb74f76f75583c43c8b59
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-06-16 (Tue, 16 Jun 2015)

  Changed paths:
    M changelog
    M players_changelog
    M src/filesystem.cpp
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  Use looks_like_pbl() to disallow .pbl file inclusion (bug #23504)

This function is implemented using case-insensitive pattern matching,
unlike filesystem::ends_with(). I missed this when writing my original
fix, so the vulnerability still applied to .pbl files on a
case-insensitive filesystem (e.g. NTFS and FAT* on Windows) by using
different case to bypass the check.





More information about the Commits mailing list