[Commits] [wesnoth/wesnoth] 02fe6c: remove unused code

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 02fe6ca39b1e0c2d2999ea1c465a7f769be17cfc
      https://github.com/wesnoth/wesnoth/commit/02fe6ca39b1e0c2d2999ea1c465a7f769be17cfc
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M src/replay.cpp

  Log Message:
  -----------
  remove unused code

stop_x/y was never writte, so i removed code that reads it.
Also i disabled variable substitution for map_locations in replay data
since it is never used.


  Commit: 0c5c72b146a081737bb58ef1e042e3cdbf8d3ab7
      https://github.com/wesnoth/wesnoth/commit/0c5c72b146a081737bb58ef1e042e3cdbf8d3ab7
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M src/replay.cpp
    M src/replay.hpp

  Log Message:
  -----------
  simplify replay::undo_cut


  Commit: cd756b74db9a254461bff32a709c24968ece7685
      https://github.com/wesnoth/wesnoth/commit/cd756b74db9a254461bff32a709c24968ece7685
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M src/synced_commands.cpp

  Log Message:
  -----------
  ignore [allow_undo] in wml menu items

becasue it casues OOS.


  Commit: 138f7c92c4f304d886f9fdee4ed028f49e22d8f4
      https://github.com/wesnoth/wesnoth/commit/138f7c92c4f304d886f9fdee4ed028f49e22d8f4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-20 (Wed, 20 May 2015)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    A src/actions/shroud_clearing_action.cpp
    A src/actions/shroud_clearing_action.hpp
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    A src/actions/undo_action.cpp
    A src/actions/undo_action.hpp
    A src/actions/undo_dismiss_action.cpp
    A src/actions/undo_dismiss_action.hpp
    A src/actions/undo_move_action.cpp
    A src/actions/undo_move_action.hpp
    A src/actions/undo_recall_action.cpp
    A src/actions/undo_recall_action.hpp
    A src/actions/undo_recruit_action.cpp
    A src/actions/undo_recruit_action.hpp
    A src/actions/undo_update_shroud_action.cpp
    A src/actions/undo_update_shroud_action.hpp

  Log Message:
  -----------
  refactor undo_action class

First we split the undo_ation into subclasses (undo_action_base, undo_action
and shroud_clearing_action) so that undo actions that don't clear shroud don't
contain the route and view_info data.
Also the non undoable actions now don't need to implement undo() and redo()

Second we move the undo action classes to different files.


  Commit: 58228b5d28e45ab442790e05c45ee66417a8cf28
      https://github.com/wesnoth/wesnoth/commit/58228b5d28e45ab442790e05c45ee66417a8cf28
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-20 (Wed, 20 May 2015)

  Changed paths:
    M src/actions/undo.cpp

  Log Message:
  -----------
  clear the redo stack when toggeling shroud updates

The previous behaviour causes OOS, assume this situation:
Player1s turn, DSU is activated, player1 moves  a unit and then undoes
the move. then he deactivates dsu and redoes the move. The result is
that the move did not uncover shroud (but it should since the move was
now done after DSU was deactivated).


Compare: https://github.com/wesnoth/wesnoth/compare/3ff2983a33bb...58228b5d28e4