[Commits] [wesnoth/wesnoth] e6de4b: image: Use IMG_Linked_Version() to obtain runtime ...

GitHub noreply at github.com
Thu May 21 08:42:02 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e6de4b4c560793ecae95f97ffb888a18882007b2
      https://github.com/wesnoth/wesnoth/commit/e6de4b4c560793ecae95f97ffb888a18882007b2
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/image.cpp

  Log Message:
  -----------
  image: Use IMG_Linked_Version() to obtain runtime SDL_image version

This is a function, not a preprocessor macro, so its existence can't be
checked using #ifdef. Furthermore, I can't think of a valid reason for
the SDL devs to arbitrary drop it in a future release without warning,
so we can safely assume it's always present for now.

(Also, it's 'IMG', not 'Image'.)


  Commit: e9f6f64f7de551b68e0411f43e6c1a6dad04d239
      https://github.com/wesnoth/wesnoth/commit/e9f6f64f7de551b68e0411f43e6c1a6dad04d239
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/image.cpp

  Log Message:
  -----------
  image: Assume SDL_IMAGE_VERSION to be always defined


  Commit: dda3e04f9ffcd142cdc191542a437744bf199fa9
      https://github.com/wesnoth/wesnoth/commit/dda3e04f9ffcd142cdc191542a437744bf199fa9
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/sound.cpp

  Log Message:
  -----------
  sound: Assume SDL_MIXER_VERSION defined, don't #ifdef Mix_Linked_Version

The latter is a function, not a preprocessor symbol, so it can't be
checked for using #ifdef.

And these aren't going away any time soon upstream.


  Commit: 6f69df12d19d38db68339eb098407603283c0a7b
      https://github.com/wesnoth/wesnoth/commit/6f69df12d19d38db68339eb098407603283c0a7b
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/network.cpp

  Log Message:
  -----------
  net: Use SDLNet_Linked_Version() to obtain runtime SDL_net version

This is a function, not a preprocessor macro, so its existence can't be
checked using #ifdef. Furthermore, I can't think of a valid reason for
the SDL devs to arbitrary drop it in a future release without warning,
so we can safely assume it's always present for now.

(Also, it's 'SDLNet', not 'Net'.)


  Commit: 1614a3bc26f10a8435071823d7cdf72880a4f272
      https://github.com/wesnoth/wesnoth/commit/1614a3bc26f10a8435071823d7cdf72880a4f272
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/network.cpp

  Log Message:
  -----------
  net: Assume SDL_NET_VERSION to be always defined


  Commit: 8d1150511a7c1962f9fe4b16b78dae7006ab3746
      https://github.com/wesnoth/wesnoth/commit/8d1150511a7c1962f9fe4b16b78dae7006ab3746
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M src/image.cpp
    M src/network.cpp
    M src/sound.cpp

  Log Message:
  -----------
  Fix typos and formatting in the SDL describe_version() helpers


Compare: https://github.com/wesnoth/wesnoth/compare/3966de749278...8d1150511a7c


More information about the Commits mailing list