[Commits] [wesnoth/wesnoth] 4a1c3f: add an assert

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4a1c3f789864d0fef4346a16f0445b2be4349cd3
      https://github.com/wesnoth/wesnoth/commit/4a1c3f789864d0fef4346a16f0445b2be4349cd3
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-29 (Fri, 29 May 2015)

  Changed paths:
    M src/synced_context.cpp
    M src/unit.cpp

  Log Message:
  -----------
  add an assert


  Commit: 33693f03f690e97495b033fbb08a4f25147df57d
      https://github.com/wesnoth/wesnoth/commit/33693f03f690e97495b033fbb08a4f25147df57d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-29 (Fri, 29 May 2015)

  Changed paths:
    M src/game_display.cpp
    M src/whiteboard/manager.hpp

  Log Message:
  -----------
  don't apply whiteboard during wesnoth.select_hex and similar.


  Commit: ce7aecc6061259f0e0d93538ead1a56e22609654
      https://github.com/wesnoth/wesnoth/commit/ce7aecc6061259f0e0d93538ead1a56e22609654
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-05-29 (Fri, 29 May 2015)

  Changed paths:
    M src/unit.cpp
    M src/unit.hpp
    M src/unit_id.cpp
    M src/unit_id.hpp

  Log Message:
  -----------
  dont create unit ids based on fake ids.

To do that i replaced the underlying_id  integer with a struct that
holds an integer and has functions to know whether this is fake id or
not.

Fake unit ids can be created via whiteboard or during unsyced contexes
(like wesnoth.sync_choice or ai code)

This commit is intended to fix the case that soneone created a temporary
unit in wesnoth.sync_choice and then returns that units id which might
not be unique   (becasue it is based on a fake id).

This commit also removes a comment that is invalid by now because config
can hold unsigned long long.


Compare: https://github.com/wesnoth/wesnoth/compare/541b1576c52a...ce7aecc60612