[Commits] [wesnoth/wesnoth] 1df73b: Call display::draw() before setting theme UI butto...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1df73b9e4c563b3a700692b5db1021e23109b1c0
      https://github.com/wesnoth/wesnoth/commit/1df73b9e4c563b3a700692b5db1021e23109b1c0
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-05-30 (Sat, 30 May 2015)

  Changed paths:
    M changelog
    M players_changelog
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  Call display::draw() before setting theme UI button states

draw() calls draw_init(), which in turn calls draw_all_panels(), which
destroys all theme UI buttons, meaning the icon overlays set on them by
set_button_state() are lost until that function is mysteriously called
at a later time, either when control is transferred to the player after
completing the start event, or the player presses the left mouse button
on the minimap buttons (??????) or some other unspecified UI event takes
place either automatically or through player interaction.

This is really a patch over f93b439e13731a49c09658a894a12a364af0b608,
where I failed to make sure one of the affected add-on scenarios would
no longer reproduce the bug before pushing.