[Commits] [wesnoth/wesnoth] 1fe513: fs: Clean up Windows-specific code in set_user_dat...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1fe5134e73cdc7c31d2f65854d6a781daf74cbc8
      https://github.com/wesnoth/wesnoth/commit/1fe5134e73cdc7c31d2f65854d6a781daf74cbc8
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fs: Clean up Windows-specific code in set_user_data_dir()

No functional changes. Probably. More about this in the next commit.


  Commit: 795dd8c4200c7ef581b9e7bf77aa03c3228723df
      https://github.com/wesnoth/wesnoth/commit/795dd8c4200c7ef581b9e7bf77aa03c3228723df
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fs: Default to Documents for user config/data on Windows

Use Documents\My Games\WesnothX.Y for user config data on Windows like
we currently do when using --config-dir there with a relative path. The
behavior of --config-dir when passed a relative path remains unchanged
with this commit, making the new out-of-the-box default equivalent to
passing --config-dir WesnothX.Y, except this is now enforced by Wesnoth
rather than a finicky installer option.

See bug #23753 for the rationale behind this change.

People who really can't live without the old CWD\userdata layout should
either use --config-dir with an absolute path to their existing userdata
dir, or wait for the next commit (which will help with "portable"
installs to removable devices, for example).


  Commit: bc22ec91760d93c23dfa6475d5f8405c4870e40c
      https://github.com/wesnoth/wesnoth/commit/bc22ec91760d93c23dfa6475d5f8405c4870e40c
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fs: Treat . and .. in userdata/config paths relative to cwd on Windows

This allows asking Wesnoth to store user files in a directory relative
to the install dir if wanted on Windows (e.g. for portable installs to
removable media where the absolute path to the install dir is not
constant or under the user's control).


  Commit: 8f8fde43bad8089c1735a37001e4a44e91f212b5
      https://github.com/wesnoth/wesnoth/commit/8f8fde43bad8089c1735a37001e4a44e91f212b5
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fs: Use SHGetFolderPath() instead of SHGetSpecialFolderPath()

The former has been "unsupported" since Windows XP, while the latter is
still supported in Vista and later as a wrapper around a newer API.

Most importantly, used this as an excuse to rewrite the code to take
advantage of the fact that we already link to SHELL32.DLL at runtime
(it implements ShellExecute() and Shell_NotifyIcon(), used elsewhere in
our code), only run on versions of Windows guarantee to provide the
SHGetFolderPath symbol, and thus don't need all the LoadLibrary mumbo
jumbo that made the code considerably uglier and denser.


  Commit: 80af2f7cdd2dca1f89a9c6cf044c25d79536cbed
      https://github.com/wesnoth/wesnoth/commit/80af2f7cdd2dca1f89a9c6cf044c25d79536cbed
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M players_changelog

  Log Message:
  -----------
  Update changelogs and release notes for bug #23573


  Commit: 2aab35bcf7e281e15b5bc587ea401cb8af3c49a5
      https://github.com/wesnoth/wesnoth/commit/2aab35bcf7e281e15b5bc587ea401cb8af3c49a5
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-10-20 (Tue, 20 Oct 2015)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M players_changelog
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  Merge branch 'bug/23753'


Compare: https://github.com/wesnoth/wesnoth/compare/f8ca1e96bc7c...2aab35bcf7e2