[Commits] [wesnoth/wesnoth] f3799b: Remove unnecessary y scrolling offset from [messag...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f3799b10ec5f46dcc0a6ff122c021532f781c5f0
      https://github.com/wesnoth/wesnoth/commit/f3799b10ec5f46dcc0a6ff122c021532f781c5f0
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-09-16 (Wed, 16 Sep 2015)

  Changed paths:
    M changelog
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Remove unnecessary y scrolling offset from [message] implementation

The problem this tried to solve was solved long ago, when the new GUI2
[message] dialog was introduced in 1.5.x. Formerly, [message] was
displayed at the top of the screen, so with sufficiently long messages
and a small screen resolution, the viewport could be scrolled in such a
way that the target unit was covered by the dialog.

Nowadays [message] is displayed at the bottom and the scrolling
algorithm is more or less sane, so this hack is completely unneeded.

(For reference, this was originally introduced in commit
83a332a8692260f50ab76bb7f0ae754baf6507d7. For a reference screenshot of
what it would do back in the day, see
<http://www.wesnoth.org/images/sshots/wesnoth-1.1.9-shot3.jpg>.)

Thanks to celticminstrel and vultraz for bringing this up on IRC.