[Commits] [wesnoth/wesnoth] cd91b5: remove unused member variable

GitHub noreply at github.com
Wed Sep 30 01:02:50 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cd91b54e29eced293cff75faf45fa0a15f18786d
      https://github.com/wesnoth/wesnoth/commit/cd91b54e29eced293cff75faf45fa0a15f18786d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/replay_controller.cpp
    M src/replay_controller.hpp

  Log Message:
  -----------
  remove unused member variable


  Commit: 65655fbb67b186d37b7d7b87310d7326e1107a49
      https://github.com/wesnoth/wesnoth/commit/65655fbb67b186d37b7d7b87310d7326e1107a49
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/hotkey_handler.hpp
    M src/hotkey_handler_replay.hpp
    M src/hotkey_handler_sp.cpp
    M src/mp_replay_controller.cpp
    M src/play_controller.hpp
    M src/replay_controller.cpp
    M src/replay_controller.hpp

  Log Message:
  -----------
  enable 'skip animation' button in mp replays


  Commit: 2c90513738c4137f3308cf3fbfb446e5d221910c
      https://github.com/wesnoth/wesnoth/commit/2c90513738c4137f3308cf3fbfb446e5d221910c
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/hotkey_handler_sp.cpp

  Log Message:
  -----------
  fix file inclusions


  Commit: 9ca66784794fa6eed0fd74558a2368f42030087e
      https://github.com/wesnoth/wesnoth/commit/9ca66784794fa6eed0fd74558a2368f42030087e
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_command.cpp
    M src/hotkey/hotkey_command.hpp
    M src/hotkey_handler_replay.cpp
    M src/hotkey_handler_replay.hpp
    M src/hotkey_handler_sp.cpp
    M src/hotkey_handler_sp.hpp
    M src/mp_replay_controller.cpp
    M src/mp_replay_controller.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/replay.cpp
    M src/replay.hpp
    M src/replay_controller.cpp
    M src/replay_controller.hpp
    M src/replay_recorder_base.cpp
    M src/replay_recorder_base.hpp

  Log Message:
  -----------
  Make is possible to switch from replay directly into normal play

http://gna.org/bugs/?23833

I removed the replay_controller class, instead the normal replay also
uses the mp_replay_controller class which is a 'plugin' to
playsingle_controller which can just be deactivated to switch into
normal gameplay.


  Commit: 703519669269f20a911d9469b6c2540b1b7658f6
      https://github.com/wesnoth/wesnoth/commit/703519669269f20a911d9469b6c2540b1b7658f6
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  remove ticks paramter from play_controllers constructor


  Commit: 9546596ad4d4e6c5bf25f63ac7e43a14f7491859
      https://github.com/wesnoth/wesnoth/commit/9546596ad4d4e6c5bf25f63ac7e43a14f7491859
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  remove story parameter from playsingle_controller::play_scenario


  Commit: 7eec2d8105488ef2f4000f1e82068474336b29e7
      https://github.com/wesnoth/wesnoth/commit/7eec2d8105488ef2f4000f1e82068474336b29e7
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  move playsingle_controller::report_victory function


  Commit: 5a82b19335d678f811bb2adf0dc26c71d9bb70d0
      https://github.com/wesnoth/wesnoth/commit/5a82b19335d678f811bb2adf0dc26c71d9bb70d0
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_state.cpp
    M src/game_state.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp

  Log Message:
  -----------
  move end_level_data_ to gamestate class


  Commit: c169150d075123af635b3a9585c7bbab3efda3eb
      https://github.com/wesnoth/wesnoth/commit/c169150d075123af635b3a9585c7bbab3efda3eb
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/hotkey_handler_sp.hpp
    M src/mp_replay_controller.cpp
    M src/mp_replay_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/replay_controller.cpp
    M src/replay_controller.hpp

  Log Message:
  -----------
  rename mp_replay_controller to replay_controller


  Commit: 9ebfec99e191622ceaf14c4efdf6d80c3db3a2ce
      https://github.com/wesnoth/wesnoth/commit/9ebfec99e191622ceaf14c4efdf6d80c3db3a2ce
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/game_initialization/playcampaign.hpp
    M src/game_launcher.cpp

  Log Message:
  -----------
  fix scenario transition after replays

Previously it was not possible to advance to the next scenario after
switching from replay into normal play.


  Commit: 7fc9a974a0516ad3da5b3551abb20b390b401e35
      https://github.com/wesnoth/wesnoth/commit/7fc9a974a0516ad3da5b3551abb20b390b401e35
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/multiplayer_lobby.cpp
    M src/game_initialization/multiplayer_lobby.hpp
    M src/game_initialization/multiplayer_ui.hpp
    M src/game_initialization/playcampaign.cpp
    M src/game_initialization/playcampaign.hpp
    M src/game_initialization/singleplayer.cpp
    M src/game_launcher.cpp
    M src/gui/dialogs/lobby_main.cpp
    M src/hotkey_handler_mp.cpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/playturn.cpp
    M src/playturn.hpp
    M src/tests/test_mp_connect.cpp
    M src/tests/utils/play_scenario.cpp

  Log Message:
  -----------
  refactor playcampaign

playcampaign's functions were moved to a new class (campaign_controller).
This removes the need to carry a lot of parameters around in playcampaign's
functions. Specially it removes those confusing boolean parameters to
play_game(). Some mp related parameters were also merged to a
mp_campaign_info struct.


  Commit: 4fa11dd3e448ac014f63ace4650c06c50934551e
      https://github.com/wesnoth/wesnoth/commit/4fa11dd3e448ac014f63ace4650c06c50934551e
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/game_state.cpp
    M src/game_state.hpp
    M src/play_controller.cpp

  Log Message:
  -----------
  partly revert 'simplify game_state construction'

It turned out that it isn't really possible to create the gamestate
without access to te gamestate from everywhere (resourcces::) the main
problem were the [effect] filters when creating units.


  Commit: 35df343caabe47105c7139fcd283b526b3a26479
      https://github.com/wesnoth/wesnoth/commit/35df343caabe47105c7139fcd283b526b3a26479
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M src/replay_controller.cpp
    M src/replay_controller.hpp

  Log Message:
  -----------
  remove unused code


  Commit: 7f24dd190758131f4c422f9109d5a37ddf94023d
      https://github.com/wesnoth/wesnoth/commit/7f24dd190758131f4c422f9109d5a37ddf94023d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M data/themes/_initial.cfg

  Log Message:
  -----------
  add 'continue game' button to replaytheme

previously this was only accesible via hotkeys


Compare: https://github.com/wesnoth/wesnoth/compare/4410f2ed87e6...7f24dd190758


More information about the Commits mailing list