[Commits] [wesnoth/wesnoth] 1a5429: attempt to fix crashes during loadingscreen

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1a542971e50040dea430fd1340f8d75781020768
      https://github.com/wesnoth/wesnoth/commit/1a542971e50040dea430fd1340f8d75781020768
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/gui/dialogs/loadscreen.cpp
    M src/gui/dialogs/loadscreen.hpp

  Log Message:
  -----------
  attempt to fix crashes during loadingscreen

currently it can happen that the game crashes during loadingscreen. The
reason is that loading scenn uses multiple threads, but t_string has a a
thread unsafe implementation that can cause crashes even when 2 threads
create 2 completeleey unrelated t_string objects.

This commit tries to fix this problem by removing all constructions of
t_string objects in the loadingscreen class to its constructor. Copy
constructors of t_string are still called, but afaik these doesn't cause
crashes liek this because they don't add new values in the t_string
hash_index registry,


  Commit: 46b4faa44bb3c18bb24ea4870b2a92e326ca2a31
      https://github.com/wesnoth/wesnoth/commit/46b4faa44bb3c18bb24ea4870b2a92e326ca2a31
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/units/unit.cpp
    M src/util.hpp

  Log Message:
  -----------
  some code cleanups.


Compare: https://github.com/wesnoth/wesnoth/compare/799695a04b1f...46b4faa44bb3