[Commits] [wesnoth/wesnoth] b681fa: fix in_chat=yes/no in [wml_message]

GitHub noreply at github.com
Sat Apr 23 13:43:38 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b681fa576ab151ea758b4ec91bd933f4f9106c43
      https://github.com/wesnoth/wesnoth/commit/b681fa576ab151ea758b4ec91bd933f4f9106c43
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-04-23 (Sat, 23 Apr 2016)

  Changed paths:
    M src/storyscreen/controller.cpp
    M src/storyscreen/part.cpp

  Log Message:
  -----------
  fix in_chat=yes/no in [wml_message]


  Commit: 1cfa62ff56a1935030bec716568712a5b806dffd
      https://github.com/wesnoth/wesnoth/commit/1cfa62ff56a1935030bec716568712a5b806dffd
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-04-23 (Sat, 23 Apr 2016)

  Changed paths:
    M src/tstring.cpp

  Log Message:
  -----------
  Attempt to fix crashes realted to multithreading and std::string

Currently t_string isn't threadsafe, of one thread executes a 't_string
a("a")' and another threads does 't_string b("b")' the progamm might
crash even of those object are completeley unrelated at first glance.

This commit tried to fix this by wrapping the acces to the shared
hash_map object in mutex locks, another attempt to fix this problem
might be to remove the shared hash_map implementation of t_string
completeley.  Unfortunateley i don't know why it was implemented this
way in the first place so i don't know which disadvantages removing it
would have.


Compare: https://github.com/wesnoth/wesnoth/compare/0ffccf6f118c...1cfa62ff56a1


More information about the Commits mailing list