[Commits] [wesnoth/wesnoth] 3cbf24: play_controller::check_victory(): use underscore i...

GitHub noreply at github.com
Thu Aug 4 14:29:11 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3cbf249b663ff957d936ac1612bfe848dcea98dd
      https://github.com/wesnoth/wesnoth/commit/3cbf249b663ff957d936ac1612bfe848dcea98dd
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-08-04 (Thu, 04 Aug 2016)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  play_controller::check_victory(): use underscore in event name

Semantically this doesn't change anything because spaces in event names are
automatically replaced with underscores.

I just spent a considerable amount of time searching for code that fires
the enemies_defeated event, only to find that it's called
"enemies defeated", with a space, at the call site. Let's use the
underscored name everywhere to make the function easier to find.





More information about the Commits mailing list