[Commits] [wesnoth/wesnoth] 10abf9: Implement lexical_cast_default as its own function

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 10abf90ff30e0c728dd58ff5c60d9104b0e515d5
      https://github.com/wesnoth/wesnoth/commit/10abf90ff30e0c728dd58ff5c60d9104b0e515d5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-12-08 (Thu, 08 Dec 2016)

  Changed paths:
    M src/lexical_cast.hpp

  Log Message:
  -----------
  Implement lexical_cast_default as its own function

As pointed out, it makes slightly more sense to keep it as two functions than one function that could
throw if the second argument were not provided. Another benefit is it allows lexical_cast_default to retain
the default T() fallback in the case where no manual fallback were provided. Whether this is desirable
behavior can be looked at later

This commit also fixes a problem in 87405f8f89c1 where the fallback value wasn't propagated through certain
specializations that called lexical_cast instead of performing the conversion themselves.


  Commit: 8c7df93d4feb3355ebc734264ff98c43ac85bb12
      https://github.com/wesnoth/wesnoth/commit/8c7df93d4feb3355ebc734264ff98c43ac85bb12
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-12-08 (Thu, 08 Dec 2016)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    M projectfiles/CodeBlocks/wesnothd.cbp
    M src/CMakeLists.txt
    M src/SConscript
    M src/editor/editor_preferences.cpp
    M src/gui/auxiliary/typed_formula.hpp
    M src/persist_context.cpp
    M src/preferences.cpp
    M src/server/ban.cpp
    M src/server/game.cpp
    M src/server/player.cpp
    M src/server/server.cpp
    M src/settings.cpp
    M src/tests/test_util.cpp
    M src/units/attack_type.cpp
    M src/units/unit.cpp
    R src/util.cpp
    M src/util.hpp
    M src/utils/make_enum.hpp
    M src/version.cpp

  Log Message:
  -----------
  Removed old implementation of lexical_cast_default


  Commit: 4d48ed13197656cf190a63505dd45e675a7072e9
      https://github.com/wesnoth/wesnoth/commit/4d48ed13197656cf190a63505dd45e675a7072e9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-12-08 (Thu, 08 Dec 2016)

  Changed paths:
    M src/actions/undo.cpp
    M src/ai/composite/aspect.hpp
    M src/ai/composite/value_translator.hpp
    M src/ai/default/recruitment.cpp
    M src/ai/lua/engine_lua.cpp
    M src/ai/manager.cpp
    M src/ai/testing.cpp
    M src/attack_prediction.cpp
    M src/campaign_server/campaign_server.cpp
    M src/color_range.cpp
    M src/config.cpp
    M src/editor/action/action.cpp
    M src/editor/map/map_fragment.cpp
    M src/filesystem_boost.cpp
    M src/filesystem_common.cpp
    M src/font/font_description.hpp
    M src/game_classification.cpp
    M src/game_data.cpp
    M src/game_events/conditional_wml.cpp
    M src/game_events/handlers.cpp
    M src/game_events/manager.cpp
    M src/game_events/manager_impl.cpp
    M src/game_launcher.cpp
    M src/generators/cave_map_generator.cpp
    M src/generators/default_map_generator_job.cpp
    M src/generators/default_map_generator_job.hpp
    M src/help/help_text_area.cpp
    M src/lobby_preferences.cpp
    M src/persist_var.cpp
    M src/playsingle_controller.cpp
    M src/playturn.cpp
    M src/saved_game.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/lua_map_location_ops.cpp
    M src/serialization/preprocessor.cpp
    M src/serialization/string_utils.cpp
    M src/serialization/unicode.cpp
    M src/server/sample_user_handler.cpp
    M src/sound.cpp
    M src/sound_music_track.cpp
    M src/statistics.cpp
    M src/storyscreen/part.cpp
    M src/team.hpp
    M src/terrain/terrain.cpp
    M src/terrain/translation.cpp
    M src/units/attack_type.hpp
    M src/units/types.cpp

  Log Message:
  -----------
  Cleaned up util.hpp includes


Compare: https://github.com/wesnoth/wesnoth/compare/e6cae2e16e40...4d48ed131976