[Commits] [wesnoth/wesnoth] 5caa9d: cleanup wml_actions.store_items

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5caa9dd95b57b17bc776ad80fb4b98fbac23256c
      https://github.com/wesnoth/wesnoth/commit/5caa9dd95b57b17bc776ad80fb4b98fbac23256c
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M data/lua/wml/items.lua

  Log Message:
  -----------
  cleanup wml_actions.store_items


  Commit: f95e23e7f8a5c4d72c8b7ab3613c6d0d7469cbc7
      https://github.com/wesnoth/wesnoth/commit/f95e23e7f8a5c4d72c8b7ab3613c6d0d7469cbc7
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp
    M src/unit_types.hpp

  Log Message:
  -----------
  fix [event]s in [unit_type]


  Commit: 63088bca62939cf48ddbd06741707cdfd53ddd7d
      https://github.com/wesnoth/wesnoth/commit/63088bca62939cf48ddbd06741707cdfd53ddd7d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp
    M src/unit_types.cpp

  Log Message:
  -----------
  remove do_not_list from unit configs.

this attribute is only used by unit_type.


  Commit: 694d43fbec5be38c4f9381614a82834e040c0554
      https://github.com/wesnoth/wesnoth/commit/694d43fbec5be38c4f9381614a82834e040c0554
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/ai/contexts.cpp

  Log Message:
  -----------
  fix crash in ai code

https://gna.org/bugs/?23780


  Commit: 5deea2eb16ebe4e717d4f4c02597081f202549e0
      https://github.com/wesnoth/wesnoth/commit/5deea2eb16ebe4e717d4f4c02597081f202549e0
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp
    M src/unit.cpp
    M src/unit.hpp
    M src/unit_types.hpp

  Log Message:
  -----------
  small unit class refactor

i moved the 'description', 'usage', 'halo', 'ellipse', 'random_traits',
'generate_name' and 'upkeep' from cfg_ into unit member variables.

This main advantage is that its now clearer which unit type attributes
exist, also it is a little faster becasue it doesn't need string lookps
when accesing those attributes.

I used scoped_ptr<string> instead of just string to store 'usage',
'halo' and 'ellipse' because that is closer to the previous memory
layout.


  Commit: eb86032d9c442964ea528c2676e90b6c8d1649e8
      https://github.com/wesnoth/wesnoth/commit/eb86032d9c442964ea528c2676e90b6c8d1649e8
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp

  Log Message:
  -----------
  remove 'image_icon' and 'image' from units cfg_

it wasn't possible to overwrite the unit types image in the [unit]
config anyway. so i changed the code to always use the image specified
in the unit type.


  Commit: 3530cbf496cd4ad7f3fb533980ae80eb12513025
      https://github.com/wesnoth/wesnoth/commit/3530cbf496cd4ad7f3fb533980ae80eb12513025
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp
    M src/unit.hpp

  Log Message:
  -----------
  remove cfg_ member from unit class

this moves profile_ and small_profile_ into member variables.

This commend out some changes to [advancement] child in cfg_ which had
no effect anyway because [advancement]s are stores in advancement_
member of the unit.


  Commit: 1f8d36306b4e2753034b2446a94d62637ec7b12b
      https://github.com/wesnoth/wesnoth/commit/1f8d36306b4e2753034b2446a94d62637ec7b12b
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp

  Log Message:
  -----------
  fix apply_to=new_advancement


  Commit: 4fd79541960c82fb87bd6b4d537b77673b709cc4
      https://github.com/wesnoth/wesnoth/commit/4fd79541960c82fb87bd6b4d537b77673b709cc4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/unit.cpp

  Log Message:
  -----------
  Optimize unit attributes check

Instead of copying all attributes to a new config and removing the known
attributes we check the config atribute set directly, to do this we use
a modified version of std::set_difference to compare the set of known
attributes with the given attributes.


  Commit: de0ad5e92af04bdb8e60bea657262658824c6e0f
      https://github.com/wesnoth/wesnoth/commit/de0ad5e92af04bdb8e60bea657262658824c6e0f
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-02-03 (Wed, 03 Feb 2016)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp
    M src/unit.hpp

  Log Message:
  -----------
  make unit.upkeep modifyable by lua.


Compare: https://github.com/wesnoth/wesnoth/compare/2aa5a965f9b9...de0ad5e92af0